[ZEPPELIN-4631]. Don't save path in note #3658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjffdu
force-pushed
the
ZEPPELIN-4631
branch
9 times, most recently
from
2c0ad82
to
383330a
Compare
|
Will merge if no more comment |
zjffdu
force-pushed
the
ZEPPELIN-4631
branch
2 times, most recently
from
b94c02f
to
bc5f308
Compare
zjffdu
force-pushed
the
ZEPPELIN-4631
branch
from
bc5f308
to
4614157
Compare
|
CI pass, will merge if no more comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR just make path in Note.java as
transient, so it won't be saved in note content. And every time it can be constructed from NotebookRepo when reading it in NoteManager which is the only way to load Note.What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: