Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused #3710

Closed
wants to merge 4 commits into from

Conversation

xiejiajun
Copy link
Contributor

What is this PR for?

  • an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete when i try remove a paragraph.

What type of PR is it?

  • Bug Fix

What is the Jira issue?

Questions:

Does the licenses files need update? NO
Is there breaking changes for older versions? NO
Does this needs documentation? NO

… interpreter may not be restarted when the interpreter process exits unexpectedly
…d to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete.
@zjffdu
Copy link
Contributor

zjffdu commented Apr 3, 2020

I think we should add throw Exception for method removeResourcesBelongsToParagraph and let the caller decide how to handle the exception. What do you think ?

@xiejiajun
Copy link
Contributor Author

I think we should add throw Exception for method removeResourcesBelongsToParagraph and let the caller decide how to handle the exception. What do you think ?

@zjffdu , i have considered this. If we do this, removeNote, removeFolder, and removeParagraph will need to handle this exception separately.

@xiejiajun
Copy link
Contributor Author

I think we should add throw Exception for method removeResourcesBelongsToParagraph and let the caller decide how to handle the exception. What do you think ?

another purpose of caught this exception in the removeResourcesBelongsToParagraph method is in order to make other running interpreters can release resources that related to the paragraph that needs to be removed. @zjffdu

@zjffdu
Copy link
Contributor

zjffdu commented Apr 7, 2020

Sorry for late response, @xiejiajun Your explanation make sense to me. I think we need to improve the exception handling where we don't have very well convention. Currently your PR LGTM for fixing this issue

asfgit pushed a commit that referenced this pull request Apr 8, 2020
…refused

### What is this PR for?
- an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete when i try remove a paragraph.

### What type of PR is it?
- Bug Fix

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4712

### Questions:
Does the licenses files need update? NO
Is there breaking changes for older versions? NO
Does this needs documentation? NO

Author: xiejiajun <xiejiajun02@163.com>
Author: xie-jia-jun <xiejiajun02@163.com>

Closes #3710 from xiejiajun/branch-0.9 and squashes the following commits:

9bb7341 [xiejiajun] Merge remote-tracking branch 'origin/branch-0.9' into branch-0.9
9bc5605 [xiejiajun] bug fix:  when we removing a paragraph , an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete.
97d2714 [xie-jia-jun] Merge pull request #2 from apache/branch-0.9
9b3c744 [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly
@asfgit asfgit closed this in 476f0e5 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants