-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8 #4230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjffdu
force-pushed
the
ZEPPELIN-5525
branch
8 times, most recently
from
September 26, 2021 01:58
1e2356d
to
83920d8
Compare
zjffdu
force-pushed
the
ZEPPELIN-5525
branch
from
September 26, 2021 04:30
83920d8
to
b816a53
Compare
CI is passed, ready for review |
Reamer
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I saw that you removed most of the pinned package versions in conda 👍
Will merge if no more comment |
asfgit
pushed a commit
that referenced
this pull request
Sep 28, 2021
### What is this PR for? The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593. * The PR fixed this issue in `zeppelin_python.py`. * This PR add tests for Python 3.8 for both python interpreter & spark interpreter (spark 2.4 doesn't support python 3.8, so there's no python 3.8 test for spark 2.4). `jupyter_client` 5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533) * bokeh test is disabled for flink interpreter. Because pyflink's dependencies conflicts with bokeh2. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5525 ### How should this be tested? * Ci pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #4230 from zjffdu/ZEPPELIN-5525 and squashes the following commits: b816a53 [Jeff Zhang] [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8 (cherry picked from commit fa1f728) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
zlosim
pushed a commit
to zlosim/zeppelin
that referenced
this pull request
Oct 22, 2021
### What is this PR for? The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593. * The PR fixed this issue in `zeppelin_python.py`. * This PR add tests for Python 3.8 for both python interpreter & spark interpreter (spark 2.4 doesn't support python 3.8, so there's no python 3.8 test for spark 2.4). `jupyter_client` 5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533) * bokeh test is disabled for flink interpreter. Because pyflink's dependencies conflicts with bokeh2. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5525 ### How should this be tested? * Ci pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#4230 from zjffdu/ZEPPELIN-5525 and squashes the following commits: b816a53 [Jeff Zhang] [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8
zlosim
pushed a commit
to zlosim/zeppelin
that referenced
this pull request
Oct 22, 2021
### What is this PR for? The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593. * The PR fixed this issue in `zeppelin_python.py`. * This PR add tests for Python 3.8 for both python interpreter & spark interpreter (spark 2.4 doesn't support python 3.8, so there's no python 3.8 test for spark 2.4). `jupyter_client` 5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533) * bokeh test is disabled for flink interpreter. Because pyflink's dependencies conflicts with bokeh2. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5525 ### How should this be tested? * Ci pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#4230 from zjffdu/ZEPPELIN-5525 and squashes the following commits: b816a53 [Jeff Zhang] [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8
JasonLeeCoding
pushed a commit
to JasonLeeCoding/zeppelin
that referenced
this pull request
Jan 5, 2022
### What is this PR for? The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593. * The PR fixed this issue in `zeppelin_python.py`. * This PR add tests for Python 3.8 for both python interpreter & spark interpreter (spark 2.4 doesn't support python 3.8, so there's no python 3.8 test for spark 2.4). `jupyter_client` 5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533) * bokeh test is disabled for flink interpreter. Because pyflink's dependencies conflicts with bokeh2. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5525 ### How should this be tested? * Ci pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#4230 from zjffdu/ZEPPELIN-5525 and squashes the following commits: b816a53 [Jeff Zhang] [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593.
zeppelin_python.py
.jupyter_client
5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533)What type of PR is it?
[Bug Fix ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: