Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8 #4230

Closed
wants to merge 1 commit into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Sep 22, 2021

What is this PR for?

The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593.

  • The PR fixed this issue in zeppelin_python.py.
  • This PR add tests for Python 3.8 for both python interpreter & spark interpreter (spark 2.4 doesn't support python 3.8, so there's no python 3.8 test for spark 2.4). jupyter_client 5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533)
  • bokeh test is disabled for flink interpreter. Because pyflink's dependencies conflicts with bokeh2.

What type of PR is it?

[Bug Fix ]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • Ci pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu zjffdu force-pushed the ZEPPELIN-5525 branch 8 times, most recently from 1e2356d to 83920d8 Compare September 26, 2021 01:58
@zjffdu
Copy link
Contributor Author

zjffdu commented Sep 26, 2021

CI is passed, ready for review

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I saw that you removed most of the pinned package versions in conda 👍

@zjffdu
Copy link
Contributor Author

zjffdu commented Sep 27, 2021

Will merge if no more comment

@asfgit asfgit closed this in fa1f728 Sep 28, 2021
asfgit pushed a commit that referenced this pull request Sep 28, 2021
### What is this PR for?

The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593.
* The PR fixed this issue in `zeppelin_python.py`.
* This PR add tests for Python 3.8 for both python interpreter & spark interpreter (spark 2.4 doesn't support python 3.8, so there's no python 3.8 test for spark 2.4).  `jupyter_client` 5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533)
* bokeh test is disabled for flink interpreter. Because pyflink's dependencies conflicts with bokeh2.

### What type of PR is it?
[Bug Fix ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5525

### How should this be tested?
* Ci pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes #4230 from zjffdu/ZEPPELIN-5525 and squashes the following commits:

b816a53 [Jeff Zhang] [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8

(cherry picked from commit fa1f728)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
zlosim pushed a commit to zlosim/zeppelin that referenced this pull request Oct 22, 2021
### What is this PR for?

The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593.
* The PR fixed this issue in `zeppelin_python.py`.
* This PR add tests for Python 3.8 for both python interpreter & spark interpreter (spark 2.4 doesn't support python 3.8, so there's no python 3.8 test for spark 2.4).  `jupyter_client` 5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533)
* bokeh test is disabled for flink interpreter. Because pyflink's dependencies conflicts with bokeh2.

### What type of PR is it?
[Bug Fix ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5525

### How should this be tested?
* Ci pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes apache#4230 from zjffdu/ZEPPELIN-5525 and squashes the following commits:

b816a53 [Jeff Zhang] [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8
zlosim pushed a commit to zlosim/zeppelin that referenced this pull request Oct 22, 2021
### What is this PR for?

The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593.
* The PR fixed this issue in `zeppelin_python.py`.
* This PR add tests for Python 3.8 for both python interpreter & spark interpreter (spark 2.4 doesn't support python 3.8, so there's no python 3.8 test for spark 2.4).  `jupyter_client` 5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533)
* bokeh test is disabled for flink interpreter. Because pyflink's dependencies conflicts with bokeh2.

### What type of PR is it?
[Bug Fix ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5525

### How should this be tested?
* Ci pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes apache#4230 from zjffdu/ZEPPELIN-5525 and squashes the following commits:

b816a53 [Jeff Zhang] [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8
JasonLeeCoding pushed a commit to JasonLeeCoding/zeppelin that referenced this pull request Jan 5, 2022
### What is this PR for?

The root cause is due to ast api is changed after python 3.8, see ipython/ipython#11593.
* The PR fixed this issue in `zeppelin_python.py`.
* This PR add tests for Python 3.8 for both python interpreter & spark interpreter (spark 2.4 doesn't support python 3.8, so there's no python 3.8 test for spark 2.4).  `jupyter_client` 5 is used because jupyter_client 7 doesn't work (tracked in ZEPPELIN-5533)
* bokeh test is disabled for flink interpreter. Because pyflink's dependencies conflicts with bokeh2.

### What type of PR is it?
[Bug Fix ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5525

### How should this be tested?
* Ci pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes apache#4230 from zjffdu/ZEPPELIN-5525 and squashes the following commits:

b816a53 [Jeff Zhang] [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants