New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Adopt maven wrapper to use the same version of Maven #4242
Conversation
I've heard of the Maven wrapper, but didn't know what the project was for until today. I read the following article about it.
|
This is a very similar mechanism with the Gradle wrapper which stores only one jar(50KB) is to get the actual Gradle version only. As you already knew, the jar is not a maven itself. It's just a wrapper program to get a specific version of Maven when running maven wrapper for the first time.
I don't think Maven is not unstable at all but the main advantage of using it is to keep the same version for CI and the development environment. If we want to multiple versions of maven as we have multiple projects using maven, it's quite complicated. If we use a maven wrapper, we don't care about the maven version for Zeppelin because maven wrapper download and use the specific version for Zeppelin project. Moreover, we don't have to install maven in my local machine to build Zeppelin - yes, I also think most Java developers already installed Maven :-) - The most important thing is that it's not mandatory to use a maven wrapper. It's just a helper feature. Everyone doesn't have to use a maven wrapper. If someone wants to use local maven, it's ok to use it as it has the same behaviors. Nonetheless, the reason why I thought I would like to adopt it is that I just want to use the same version of CI. (Recently, I got different warning messages between CI and my local machine.) |
I would like to merge it if there isn't any further opinion. I believe that some people use this feature very usefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jongyoul This is not a small change, it's better to create a ticket for it. |
Using maven wrapper when building and testing [Improvement] * [ ] - Change `mvn` to `./mvnw` N/A Pass CI * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <jongyoul@gmail.com> Closes apache#4242 from jongyoul/minor/add-mvnw and squashes the following commits: a606683 [Jongyoul Lee] [MINOR] adopt maven wrapper to use the same version of Maven d5e9bbb [Jongyoul Lee] [MINOR] adopt maven wrapper to use the same version of Maven 75300ce [Jongyoul Lee] [MINOR] Add mvnw in order to use the same version of maven
Using maven wrapper when building and testing [Improvement] * [ ] - Change `mvn` to `./mvnw` N/A Pass CI * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <jongyoul@gmail.com> Closes apache#4242 from jongyoul/minor/add-mvnw and squashes the following commits: a606683 [Jongyoul Lee] [MINOR] adopt maven wrapper to use the same version of Maven d5e9bbb [Jongyoul Lee] [MINOR] adopt maven wrapper to use the same version of Maven 75300ce [Jongyoul Lee] [MINOR] Add mvnw in order to use the same version of maven
### What is this PR for? Using maven wrapper when building and testing ### What type of PR is it? [Improvement] ### Todos * [ ] - Change `mvn` to `./mvnw` ### What is the Jira issue? N/A ### How should this be tested? Pass CI ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <jongyoul@gmail.com> Closes apache#4242 from jongyoul/minor/add-mvnw and squashes the following commits: a606683 [Jongyoul Lee] [MINOR] adopt maven wrapper to use the same version of Maven d5e9bbb [Jongyoul Lee] [MINOR] adopt maven wrapper to use the same version of Maven 75300ce [Jongyoul Lee] [MINOR] Add mvnw in order to use the same version of maven
What is this PR for?
Using maven wrapper when building and testing
What type of PR is it?
[Improvement]
Todos
mvn
to./mvnw
What is the Jira issue?
N/A
How should this be tested?
Pass CI
Screenshots (if appropriate)
Questions: