[ZEPPELIN-5702] Refactor spark interpreter module structure #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjffdu
force-pushed
the
ZEPPELIN-5702
branch
5 times, most recently
from
b196540
to
2b9fe2c
Compare
zjffdu
changed the title
zjffdu
force-pushed
the
ZEPPELIN-5702
branch
3 times, most recently
from
ce5abd2
to
8e0c0ad
Compare
zjffdu
changed the title
zjffdu
force-pushed
the
ZEPPELIN-5702
branch
4 times, most recently
from
acf8c5e
to
1131564
Compare
|
Will merge if no more comment |
|
I merged it. Thank you :-) |
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently, there's one
spark-scala-parentmodule which is shared by multiple scala module. This can reduce code duplication, but bring difficulties for developing spark module. It is not easy for new developers to configure it properly in IDE and run unit test in IDE.This PR is to restructure the spark module: move the code in spark-scala-parent to each scala module (scala-2.11,scala-2.12,scala-2.13), this would cause code duplication, but ease the development phase and maintenance.
After this PR, you can run spark unit test directly without any extra configuration in intellij.
What type of PR is it?
[Improvement | Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: