[ZEPPELIN-5744] Allow NoteManager for concurrent operation #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongyoul
approved these changes
May 30, 2022
Reamer
reviewed
May 30, 2022
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java
Outdated
Show resolved
Hide resolved
Reamer
reviewed
May 30, 2022
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java
Outdated
Show resolved
Hide resolved
Reamer
reviewed
May 30, 2022
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java
Outdated
Show resolved
Hide resolved
Reamer
reviewed
May 30, 2022
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java
Outdated
Show resolved
Hide resolved
Reamer
requested changes
May 30, 2022
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java
Outdated
Show resolved
Hide resolved
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java
Outdated
Show resolved
Hide resolved
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java
Show resolved
Hide resolved
akoira
pushed a commit
to akoira/zeppelin
that referenced
this pull request
Jun 24, 2022
akoira
pushed a commit
to akoira/zeppelin
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
When multi users perform some notebook/folder operation, like rename or move, some notebooks become not accessible from zeppelin page, while they are still existing on the HDFS, and only resort to restart Zeppelin daemon to solve the problem.
In this PR, unit test is created to simulate the concurrent request scenario and reproduce the issue successfully, including the operations of saveNote, moveNote, moveFolder and removeNote.
Accordingly, some changes are made to ensure thread safety of note manager operation, so that the note or folder info will not be lost, after which the unit test should get passed.
What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
Questions: