New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-5191] Fix the wrong Docker image name in zeppelin-server.yaml #4439
Conversation
- There has never been any Docker image named `zeppelin-interpreter` or `zeppelin-server`. - The latest version also should be 0.10.1
@maziyarpanahi Hello, BTW what is this?
|
Apologies, I forgot the next line:
I wanted to make sure everything in this quick start works as expected: https://zeppelin.apache.org/docs/0.10.1/quickstart/kubernetes.html#quickstart |
Hello @maziyarpanahi Zeppelin is quite complex and I agree that the documentation is not very useful. On the whole, I would like to get rid of the apache/zeppelin docker image as it is not really suitable for K8s. I envision the following process: Can you perhaps perform the process as an outsider and adjust the documentation accordingly. |
Hi @Reamer Yes, I will follow these steps to
I'll share the process here before we decide how to update the docs to reflect these steps. (it should be straightforward) |
- How to build zeppelin-distribution - How to build zeppelin-server - How to build zeppelin-interpreter - How to use ./k8s/zeppelin-server.yaml script to correctly launch Zeppelin on Kubernetes cluster
Hi @Reamer I have added the steps to build Please let me know if you want me to adjust something further. |
Very good, that is how I imagined it. I would remove the change in |
This commit will remove the step-by-step editing of zeppelin-server.yaml and replacing it with a simple reminder to adjust the names in this file
Thanks @Reamer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ml (apache#4439) * Fix the wrong Docker image name - There has never been any Docker image named `zeppelin-interpreter` or `zeppelin-server`. - The latest version also should be 0.10.1 * Add more instructions for running Zeppelin on K8s - How to build zeppelin-distribution - How to build zeppelin-server - How to build zeppelin-interpreter - How to use ./k8s/zeppelin-server.yaml script to correctly launch Zeppelin on Kubernetes cluster * Adding a reminder to adjust images' names This commit will remove the step-by-step editing of zeppelin-server.yaml and replacing it with a simple reminder to adjust the names in this file
zeppelin-interpreter
orzeppelin-server
.What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
All the examples inside and outside Zeppelin website/docs point to simply using
zeppelin-server.yaml
for K8s cluster :There are lots of issues on StackOverFlow and 1 on Jira that indicate the Docker images mentioned in this YAML simply don't exist on Docker Hub.
What type of PR is it?
Documentation
Please leave your type of PR only
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5191
How should this be tested?
I have tested this on a live K8s cluster (OpenStack) and it created a Zeppelin server successfully, also creates Spark and other interpreters in the cluster upon request without any issue:
Screenshots (if appropriate)
Questions: