Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-5493] Remove prefix in jdbc interpreter #4463

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

huage1994
Copy link
Contributor

What is this PR for?

Currently, zeppelin allow user to run multiple kinds of sql in one interpreter, e.g.

%jdbc(db=mysql)
%jdbc(db=hive){code}

 
But this would make jdbc interpreter very complicated, and hard to maintain.
 
This PR is to proposal to remove this feature, so that user need to create separated interpreter for each database.

%mysql
%hive

What type of PR is it?

Refactoring

Todos

  • - Task

What is the Jira issue?

How should this be tested?

CI passed

Screenshots (if appropriate)

Questions:

  • Does the licenses files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@huage1994 huage1994 marked this pull request as draft September 9, 2022 11:42
@huage1994 huage1994 force-pushed the ZEPPELIN-5493 branch 2 times, most recently from 6330df7 to 1565dcc Compare September 11, 2022 01:35
@huage1994 huage1994 changed the title Remove prefix in jdbc interpreter [ZEPPELIN-5493] Remove prefix in jdbc interpreter Sep 13, 2022
@jongyoul
Copy link
Member

BTW, don't it have a doc as well?

@huage1994
Copy link
Contributor Author

BTW, don't it have a doc as well?

Thanks @jongyoul for reminding!
I found the hive related doc still have usage of this feature. I'll update it and verify.

@huage1994 huage1994 marked this pull request as ready for review September 28, 2022 07:02
@huage1994
Copy link
Contributor Author

BTW, don't it have a doc as well?

Thanks @jongyoul for reminding! I found the hive related doc still have usage of this feature. I'll update it and verify.

Finished.

@zjffdu zjffdu self-requested a review October 25, 2022 02:01
@zjffdu
Copy link
Contributor

zjffdu commented Oct 25, 2022

LGTM, will merge if no more comment

@huage1994
Copy link
Contributor Author

Hi @jongyoul , thanks a lot for your review! Is there any code I need to change?
Merging can be performed automatically once the requested changes are addressed.
It seems that change requested state can only be addressed by reviewer.

@zjffdu zjffdu merged commit 679b3fb into apache:master Oct 28, 2022
proceane pushed a commit to proceane/zeppelin that referenced this pull request Feb 16, 2023
* Remove prefix in jdbc interpreter

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants