-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-5493] Remove prefix in jdbc interpreter #4463
Conversation
jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
Outdated
Show resolved
Hide resolved
6330df7
to
1565dcc
Compare
1565dcc
to
9e9ed31
Compare
BTW, don't it have a doc as well? |
Thanks @jongyoul for reminding! |
91a52f1
to
3306e75
Compare
Finished. |
LGTM, will merge if no more comment |
Hi @jongyoul , thanks a lot for your review! Is there any code I need to change? |
* Remove prefix in jdbc interpreter * update docs
What is this PR for?
Currently, zeppelin allow user to run multiple kinds of sql in one interpreter, e.g.
But this would make jdbc interpreter very complicated, and hard to maintain.
This PR is to proposal to remove this feature, so that user need to create separated interpreter for each database.
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
How should this be tested?
CI passed
Screenshots (if appropriate)
Questions: