Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-5884] fix: wrong path of test folder in Java Interpreter #4569

Merged
merged 1 commit into from Feb 24, 2023

Conversation

tranvanthai
Copy link
Contributor

@tranvanthai tranvanthai commented Feb 23, 2023

What is this PR for?

Currently, the path of the test folder in the Java Interpreter module was wrong. I open this PR to correct it.

What type of PR is it?

Improvement

Todos

  • - Move the test folder of Java Interpreter to the correct path

What is the Jira issue?

How should this be tested?

  • Check the test was run

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Reamer Reamer self-requested a review February 23, 2023 11:01
Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. The test classes are now respected, also by Checkstyle. Please correct the Checkstyle errors.
https://github.com/apache/zeppelin/actions/runs/4249994176/jobs/7394695038

@Reamer
Copy link
Contributor

Reamer commented Feb 24, 2023

The tests run through, but without log output. In my opinion, this can be omitted at the moment. How do you see it?

2023-02-24T08:53:44.5652238Z [INFO] -------------------------------------------------------
2023-02-24T08:53:44.5652658Z [INFO]  T E S T S
2023-02-24T08:53:44.5653098Z [INFO] -------------------------------------------------------
2023-02-24T08:53:45.0138413Z [INFO] Running org.apache.zeppelin.java.JavaInterpreterUtilsTest
2023-02-24T08:53:45.5101854Z [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.495 s - in org.apache.zeppelin.java.JavaInterpreterUtilsTest
2023-02-24T08:53:45.5108854Z [INFO] Running org.apache.zeppelin.java.JavaInterpreterTest
2023-02-24T08:53:45.6120582Z log4j:WARN No appenders could be found for logger (org.apache.zeppelin.java.StaticRepl).
2023-02-24T08:53:45.6121148Z log4j:WARN Please initialize the log4j system properly.
2023-02-24T08:53:45.6121610Z log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
2023-02-24T08:53:45.6155493Z [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.103 s - in org.apache.zeppelin.java.JavaInterpreterTest
2023-02-24T08:53:45.9381040Z [INFO] 
2023-02-24T08:53:45.9381487Z [INFO] Results:
2023-02-24T08:53:45.9381784Z [INFO] 
2023-02-24T08:53:45.9383174Z [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0

@Reamer Reamer merged commit efc5fb8 into apache:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants