[ZEPPELIN-5897] Remove launcher properties and only use the current context properties

[Reamer]

What is this PR for?

This PR removes the double holding of properties.
The main problem: The InterpreterLauncher class is a singleton, because of your PluginManager Cache Implementation.

https://github.com/apache/zeppelin/blob/22ae6cdcd1f526b66808c2b994b53f808f390cfe/zeppelin-zengine/src/main/java/org/apache/zeppelin/plugin/PluginManager.java#L104C23-L126

As a result, every InterpreterProcess started by an InterpreterLauncher has the same properties, because we have the following lines of code in almost all launchers.

zeppelin/zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnInterpreterLauncher.java

Line 44 in 22ae6cd

this.properties = context.getProperties();

zeppelin/zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sStandardInterpreterLauncher.java

Line 107 in 22ae6cd

this.properties = context.getProperties();

The problem that arises here is when multiple jobs are started in parallel via CronJobs using one launcher. In the end, the "last" process overwrites the properties of the previous ones. This makes problems, if the individual InterpreterProcesses adjust the properties, as for example in the K8sInterpreterProcess.

zeppelin/zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcess.java

Lines 447 to 458 in 22ae6cd

	private void addSparkK8sProperties() {
	properties.setProperty("spark.master", "k8s://https://kubernetes.default.svc");
	properties.setProperty("spark.submit.deployMode", "client");
	properties.setProperty("spark.kubernetes.namespace", getInterpreterNamespace());
	properties.setProperty("spark.kubernetes.driver.pod.name", getPodName());
	properties.setProperty("spark.kubernetes.container.image", properties.containsKey(SPARK_CONTAINER_IMAGE) ?
	properties.getProperty(SPARK_CONTAINER_IMAGE) : sparkImage);
	properties.setProperty("spark.driver.bindAddress", "0.0.0.0");
	properties.setProperty("spark.driver.host", getInterpreterPodDnsName());
	properties.setProperty("spark.driver.port", String.valueOf(getSparkDriverPort()));
	properties.setProperty("spark.blockManager.port", String.valueOf(getSparkBlockManagerPort()));
	}

For this reason, this PR removes the properties in the launcher object and all launchers are forced to access the properties in the current context.

What type of PR is it?

Bug Fix
Improvement
Refactoring

What is the Jira issue?

• https://issues.apache.org/jira/browse/ZEPPELIN-5897

How should this be tested?

• CI

Questions:

• Does the license files need to update? No
• Is there breaking changes for older versions? No
• Does this needs documentation? No

[jongyoul]

BTW,

Keep failing again?

[Reamer]

Keep failing again?

Yes the selenium test is very unstable.

[jongyoul]

Keep failing again?

Yes the selenium test is very unstable.

Let me check it sooner than later 😢

[Reamer]

I will observe this feature a bit more in my productive environment. So far, everything looks very good.