Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-5921] Fix sync with remote repository #4610

Merged
merged 3 commits into from Jun 2, 2023

Conversation

matthias-koch
Copy link
Contributor

What is this PR for?

If you use the plugin GithubNotebookRepo to sync the notes with a remote git repository, moved and deleted notes are not synced.
This issue has been fixed.

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5921

How should this be tested?

  • New unit test were added

Questions:

  • Does the license files need to update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

Reamer
Reamer previously approved these changes May 30, 2023
Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reamer
Copy link
Contributor

Reamer commented May 31, 2023

Will merge this PR on Friday as long as no other comments are received.

@Reamer Reamer self-assigned this May 31, 2023
@Reamer Reamer merged commit ce577ad into apache:master Jun 2, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants