Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Validate note name #4632

Merged
merged 6 commits into from Jul 18, 2023

Conversation

jongyoul
Copy link
Member

What is this PR for?

Checking invalid note name like './';

What type of PR is it?

Hot Fix

Todos

  • - Add validation logic for note names

What is the Jira issue?

  • N/A

How should this be tested?

  • Invalid note name should be rejected

Screenshots (if appropriate)

  • N/A

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jongyoul jongyoul self-assigned this Jul 10, 2023
jongyoul and others added 2 commits July 11, 2023 00:30
…bookServiceTest.java

Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>
…bookService.java

Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>
Reamer
Reamer previously approved these changes Jul 10, 2023
@jongyoul jongyoul merged commit f025a69 into apache:master Jul 18, 2023
23 checks passed
akoira pushed a commit to akoira/zeppelin that referenced this pull request Feb 1, 2024
* [HOTFIX] Validate note name

* [HOTFIX] Validate note name

* [HOTFIX] Validate note name

* Update zeppelin-server/src/test/java/org/apache/zeppelin/service/NotebookServiceTest.java

Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>

* Update zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java

Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>

* [HOTFIX] Fix commented

---------

Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>
dmetasoul01 pushed a commit to meta-soul/zeppelin that referenced this pull request May 14, 2024
* [HOTFIX] Validate note name

* [HOTFIX] Validate note name

* [HOTFIX] Validate note name

* Update zeppelin-server/src/test/java/org/apache/zeppelin/service/NotebookServiceTest.java

Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>

* Update zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java

Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>

* [HOTFIX] Fix commented

---------

Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants