[ZEPPELIN-5979] Support and use Python 3.9 in default #4690
Conversation
| @@ -35,4 +36,4 @@ dependencies: | |||
| - r-irkernel | |||
| - r-shiny | |||
| - r-googlevis | |||
| - tensorflow=1.13 | |||
| - tensorflow | |||
There was a problem hiding this comment.
It's only used in submarine testing.
BTW, does the community consider removing submarine support?
- submarine was listed at here with no clear decision
- there is no functionality change / bugfix in submarine module since 2020
- submarine already provided the built notebook in the new version, and submarine docs does not mention zeppelin
thus, I suppose we can remove it?
There was a problem hiding this comment.
I do not use submarine. As long as it doesn't cause any problems, we should keep it.
There was a problem hiding this comment.
@Reamer OK, thanks for your advice.
|
also cc @zjffdu and @huage1994 |
| python: [ 3.9 ] | ||
| flink: [116, 117] | ||
| include: | ||
| # Flink 1.15 supports Python 3.6, 3.7, and 3.8 |
There was a problem hiding this comment.
The comment needs to be updated
There was a problem hiding this comment.
Umm, maybe I am nitpicking. I thought you were going to test all the three python versions, following the comments.
There was a problem hiding this comment.
Flink 1.15 is an exception, it does not work with Python 3.9, that's why I leave comments to explain that.
| @@ -35,4 +36,4 @@ dependencies: | |||
| - r-irkernel | |||
| - r-shiny | |||
| - r-googlevis | |||
| - tensorflow=1.13 | |||
| - tensorflow | |||
| @@ -342,8 +353,13 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python: [ 3.7, 3.8 ] | |||
| python: [ 3.9 ] | |||
There was a problem hiding this comment.
why not modify to [ 3.7, 3.8, 3.9 ] ?
There was a problem hiding this comment.
I think we don't need to test all combinations of Java and Python.
all_java_version * default_python_version plus default_java_version * all_python_version_except_default_one is sufficient.
There was a problem hiding this comment.
I think we don't need to test all combinations of Java and Python.
all_java_version * default_python_versionplusdefault_java_version * all_python_version_except_default_oneis sufficient.
Thank you very much for explaining.
What is this PR for?
Currently, Zeppelin only tests with Python 3.7(default) and 3.8.
According to https://endoflife.date/, Python 3.7 is EOL. This PR adds the Python 3.9 test with minimal tunes. Although Python 3.12 is available, I conservatively just moved to Python 3.9 for safety (I'm not a Python expert), also Python 3.9 is the first version officially supporting Apple Sillicon.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-5979
How should this be tested?
Pass GA.
Screenshots (if appropriate)
Questions: