[ZEPPELIN-5983] Upgrade to NodeJS 16 #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Nov 19, 2023
| <node.version>v12.3.1</node.version> | ||
| <npm.version>6.9.0</npm.version> | ||
| <node.version>v16.20.2</node.version> | ||
| <npm.version>8.19.4</npm.version> |
There was a problem hiding this comment.
after I perform nvm install 16
(zeppelin) ➜ zeppelin-web-angular git:(ZEPPELIN-5983) node --version
v16.20.2
(zeppelin) ➜ zeppelin-web-angular git:(ZEPPELIN-5983) npm --version
8.19.4
pan3793
force-pushed
the
ZEPPELIN-5983
branch
from
48b1c62
to
52cf088
Compare
pan3793
force-pushed
the
ZEPPELIN-5983
branch
from
52cf088
to
adde613
Compare
jongyoul
approved these changes
Nov 20, 2023
akoira
pushed a commit
to akoira/zeppelin
that referenced
this pull request
Feb 1, 2024
* [ZEPPELIN-5983] Upgrade to NodeJS 16 * empty * regenerate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR aims to upgrade the NodeJS from 12 to 16, in
zeppelin-webandzeppelin-web-angularmodules.In this upgrade, I try my best to minimize the changes. NodeJS 12 is a pretty old one, and NodeJS 16(it was EOL recently too[1]) was chosen as a kind of balance because this project uses some pretty old versions of dependencies. e.g. it's recommended to upgrade to webpack 6 to work with NodeJS 18[2], but Zeppelin uses webpack 3
[1] https://endoflife.date/nodejs
[2] webpack/webpack#14532
What type of PR is it?
Todos
What is the Jira issue?
ZEPPELIN-5983
How should this be tested?
Pass CI, and manually test by randomly clicking the Web UI page to test the basic functionalities.
Screenshots (if appropriate)
The legacy UI
The new UI
Questions: