Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeppelin 26 #47

Closed
wants to merge 4 commits into from
Closed

Zeppelin 26 #47

wants to merge 4 commits into from

Conversation

cfmcgrady
Copy link

Base on this branch(https://github.com/Leemoonsoo/incubator-zeppelin/tree/ZEPPELIN-26). add HDFSNotebookRepo.

@Leemoonsoo
Copy link
Member

Hi, @cfmcgrady. Thanks for contribution.

Constructor type for NotebookRepo is slightly changed.
from NotebookRepo(ZeppelinConfiguration conf, URI uri) to NotebookRepo(ZeppelinConfiguration conf). Please rebase this branch with master branch.

One concern is
Currently zeppelin-daemon process and interpreter process uses common.sh to construct it's classpath.
Once zeppelin-daemon have HDFS dependencies, then by common.sh, it'll be also loaded into every interpreter process. Especially spark include HDFS related dependency, too, they'll conflict.

And version of HDFS related dependency's is fixed. i think it'll be better if it is configurable.

@cfmcgrady
Copy link
Author

@Leemoonsoo.
so which is better way make version of HDFS configurable.

@Leemoonsoo
Copy link
Member

@cfmcgrady I think using maven property is an option for making HDFS version configurable. For example spark interpreter is already doing it.

@jongyoul
Copy link
Member

@cfmcgrady Do you have any update for this? Otherwise, Could you please close this PR?

@corneadoug
Copy link
Contributor

@cfmcgrady Is this PR still relevant?
Otherwise I will close it

@asfgit asfgit closed this in 7ef2e58 Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants