Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Escape Ldap search filters #4714

Merged
merged 2 commits into from Feb 27, 2024

Conversation

jongyoul
Copy link
Member

What is this PR for?

Escaping Ldap filters to mitigate un-intended behaviors

What type of PR is it?

Hot Fix

Todos

What is the Jira issue?

N/A

How should this be tested?

  • CI should be green

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Reamer
Copy link
Contributor

Reamer commented Feb 19, 2024

Is there no ready-made implementation, e.g. in Java or in the Shiro project?

@jongyoul
Copy link
Member Author

jongyoul commented Feb 19, 2024

After you commented, I tried to find related code in javax.security and shiro. I, however, couldn't find a similar one.

@jongyoul
Copy link
Member Author

ping @zjffdu @Reamer @huage1994

FYI, it's a kind of potential security issue so please review it if you have time.

@jongyoul jongyoul merged commit 65d0bcc into apache:master Feb 27, 2024
31 checks passed
jongyoul added a commit that referenced this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants