Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-947: Change docs link to point the same Zeppelin version #953

Closed
wants to merge 1 commit into from

Conversation

AhyoungRyu
Copy link
Contributor

What is this PR for?

Currently, Zeppelin documentation link in Zeppelin home is pointing to http://zeppelin.apache.org/docs/latest/index.html. But maybe some people is not using the latest version. So the link should point to the same Zeppelin version that user is using now.

I just change the latest -> {{zeppelinVersion}}

What type of PR is it?

Improvement

Todos

What is the Jira issue?

ZEPPELIN-947

How should this be tested?

  1. After applying this patch and browse Zeppelin home.
  2. Just click Zeppelin Documentation link in here
    screen shot 2016-06-02 at 1 11 17 pm

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@AhyoungRyu AhyoungRyu closed this Jun 2, 2016
@AhyoungRyu AhyoungRyu reopened this Jun 2, 2016
@corneadoug
Copy link
Contributor

The CI failure is unrelated,
Tested, LGTM

@prabhjyotsingh
Copy link
Contributor

I have seen in some of the organisations where the build/release team edits pom.xml and truncates -SNAPSHOT e.g. 0.6.0-SNAPSHOT becomes 0.6.0, for their own cache purposes.

So, IMO if we are going ahead with this, then may be we should have a redirect of http://zeppelin.apache.org/docs/{anything-else}/index.html to http://zeppelin.apache.org/docs/latest/index.html. Any thoughts ?

@Leemoonsoo
Copy link
Member

Leemoonsoo commented Jun 4, 2016

@prabhjyotsingh redirection is good idea. Created an issue and pullrequest.

@AhyoungRyu
Copy link
Contributor Author

@prabhjyotsingh Appreciate for sharing your thought! and
@Leemoonsoo Thanks for taking care that :)

@corneadoug
Copy link
Contributor

@Leemoonsoo not sure your PR is doing it, the idea was to use latest instead of 0.6.0-SNAPSHOT

@Leemoonsoo
Copy link
Member

@corneadoug updated #961, please check!

@prabhjyotsingh
Copy link
Contributor

LGTM. We can merge this if no more discussion.

@felixcheung
Copy link
Member

but latest is generally older than the unreleased snapshot build?
for instance, https://zeppelin.incubator.apache.org/docs/latest/ now points to 0.5.6 release doc, not 0.6.0-snapshot doc.

@AhyoungRyu
Copy link
Contributor Author

@felixcheung Yeah right. As you can see, that's why I changed the link http://zeppelin.apache.org/docs/latest/index.html -> http://zeppelin.apache.org/docs/{{zeppelinVersion}}/index.html. Did I understand your comment incorrectly ?

@felixcheung
Copy link
Member

Right. This is good. I was not sure about the redirect comment above but I didn't really have a better solution.

    _____________________________

@asfgit asfgit closed this in 11e789e Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants