Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-961] Longer names to the notebook make the name-text and buttons float outside the border. #971

Closed

Conversation

sagarkulkarni3592
Copy link
Contributor

@sagarkulkarni3592 sagarkulkarni3592 commented Jun 7, 2016

What is this PR for?

To correct the styling of notebook header which has notebook name, in case when the name is longer.
Feature : We should not limit the name size, but, while showing we can limit the name text to be shown.

What type of PR is it?

[Bug Fix]

Todos

What is the Jira issue?

ZEPPELIN-961

How should this be tested?

  • Open any notebook.
  • Give the long name.

Screenshots

Before bug fix :
screen shot 2016-06-07 at 11 16 14 am
After bug fix :
screen shot 2016-06-07 at 11 17 15 am
screen shot 2016-06-07 at 11 17 31 am

Questions:

  • Does the licenses files need update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

@sagarkulkarni3592 sagarkulkarni3592 force-pushed the ZEPPELIN-961 branch 8 times, most recently from 9668619 to 3a9258e Compare June 8, 2016 06:15
@minahlee
Copy link
Member

minahlee commented Jun 8, 2016

It would be better if we make it to be responsive to window width size.
Attaching my screenshot
screen shot 2016-06-08 at 10 35 40 am

@sagarkulkarni3592
Copy link
Contributor Author

@minahlee Thank you for that suggestion.
What if we push all the buttons to the new div present on next line, like :
screen shot 2016-06-09 at 3 44 20 pm
This will change the look.
If not, then we could adjust the shown name size.

@minahlee
Copy link
Member

I would prefer to keep noteAction size as default height. As a Zeppelin user I prefer to see more of my work space than notebook name and buttons.

@sagarkulkarni3592
Copy link
Contributor Author

I have adjusted the noteAction size by adjusting name component of the noteAction bar.
screen shot 2016-06-16 at 11 46 44 am
But, still there is a problem if the window size is reduced below that. It is because, all the buttons can not be fit in that div. So they overflow. Below is the screenshot if we don't show the name at all.
screen shot 2016-06-16 at 11 53 09 am

What should be the exact requirement in this case?

@sagarkulkarni3592 sagarkulkarni3592 force-pushed the ZEPPELIN-961 branch 5 times, most recently from 61ba882 to c912f91 Compare June 17, 2016 06:10
@minahlee
Copy link
Member

@sagarkulkarni3592 Could you rebase and resolve conflicts?

@sagarkulkarni3592
Copy link
Contributor Author

@minahlee Resolved the conflicts. Build is failing for non-related reasons.

@minahlee
Copy link
Member

Thanks for the update. I see one more thing needs to be handled.
Could you make btn group not to cover input box in below screenshot?
screen shot 2016-06-21 at 11 03 56 pm

@sagarkulkarni3592
Copy link
Contributor Author

@minahlee Done the changes necessary to make the overlap go away.

screen shot 2016-06-22 at 12 45 34 pm

@sagarkulkarni3592
Copy link
Contributor Author

Also, observed this. When the notebook name is shorter, buttons appear far from the name or box as shown.

screen shot 2016-06-22 at 12 48 00 pm
screen shot 2016-06-22 at 12 48 16 pm

After the commit, it is made more dynamic.

screen shot 2016-06-22 at 12 48 34 pm
screen shot 2016-06-22 at 12 48 46 pm

@sagarkulkarni3592
Copy link
Contributor Author

@minahlee Also merged it with the master branch.

@minahlee
Copy link
Member

LGTM merging it into master and branch-0.6

@asfgit asfgit closed this in 056eee8 Jun 25, 2016
asfgit pushed a commit that referenced this pull request Jun 25, 2016
…ttons float outside the border.

### What is this PR for?
To correct the styling of notebook header which has notebook name, in case when the name is longer.
Feature : We should not limit the name size, but, while showing we can limit the name text to be shown.

### What type of PR is it?
[Bug Fix]

### Todos

### What is the Jira issue?
[ZEPPELIN-961](https://issues.apache.org/jira/browse/ZEPPELIN-961)

### How should this be tested?
- Open any notebook.
- Give the long name.

### Screenshots
Before bug fix :
![screen shot 2016-06-07 at 11 16 14 am](https://cloud.githubusercontent.com/assets/12127192/15847327/a521e768-2ca2-11e6-935c-1114dfabfd76.png)
After bug fix :
![screen shot 2016-06-07 at 11 17 15 am](https://cloud.githubusercontent.com/assets/12127192/15847326/a51fc7da-2ca2-11e6-867d-9cd421abc8dc.png)
![screen shot 2016-06-07 at 11 17 31 am](https://cloud.githubusercontent.com/assets/12127192/15847328/a621e50a-2ca2-11e6-8b34-2738c998bb4d.png)

### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.

Author: Sagar Kulkarni <sagarkulkarni3592@gmail.com>

Closes #971 from sagarkulkarni3592/ZEPPELIN-961 and squashes the following commits:

f7202c0 [Sagar Kulkarni] Merge branch 'master' of https://github.com/apache/incubator-zeppelin into ZEPPELIN-961
ff88f41 [Sagar Kulkarni] Made buttons position dynamic to size of name.
a42045e [Sagar Kulkarni] Fixed the input box and button overlap.
9b29d8a [Sagar Kulkarni] Merge branch 'master' of https://github.com/apache/incubator-zeppelin into ZEPPELIN-961
37012ad [Sagar Kulkarni] Made adjustment to the name when window size is changed.
29607e5 [Sagar Kulkarni] ZEPPELIN-961 - Fixed the floating problem as well as styling of buttons.

(cherry picked from commit 056eee8)
Signed-off-by: Mina Lee <minalee@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants