New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-961] Longer names to the notebook make the name-text and buttons float outside the border. #971
Conversation
9668619
to
3a9258e
Compare
3a9258e
to
29607e5
Compare
@minahlee Thank you for that suggestion. |
I would prefer to keep |
61ba882
to
c912f91
Compare
c912f91
to
37012ad
Compare
@sagarkulkarni3592 Could you rebase and resolve conflicts? |
f4e47b8
to
e3a8377
Compare
…into ZEPPELIN-961
e3a8377
to
9b29d8a
Compare
@minahlee Resolved the conflicts. Build is failing for non-related reasons. |
@minahlee Done the changes necessary to make the overlap go away. |
e9594dc
to
ff88f41
Compare
…into ZEPPELIN-961
@minahlee Also merged it with the master branch. |
LGTM merging it into master and branch-0.6 |
…ttons float outside the border. ### What is this PR for? To correct the styling of notebook header which has notebook name, in case when the name is longer. Feature : We should not limit the name size, but, while showing we can limit the name text to be shown. ### What type of PR is it? [Bug Fix] ### Todos ### What is the Jira issue? [ZEPPELIN-961](https://issues.apache.org/jira/browse/ZEPPELIN-961) ### How should this be tested? - Open any notebook. - Give the long name. ### Screenshots Before bug fix : ![screen shot 2016-06-07 at 11 16 14 am](https://cloud.githubusercontent.com/assets/12127192/15847327/a521e768-2ca2-11e6-935c-1114dfabfd76.png) After bug fix : ![screen shot 2016-06-07 at 11 17 15 am](https://cloud.githubusercontent.com/assets/12127192/15847326/a51fc7da-2ca2-11e6-867d-9cd421abc8dc.png) ![screen shot 2016-06-07 at 11 17 31 am](https://cloud.githubusercontent.com/assets/12127192/15847328/a621e50a-2ca2-11e6-8b34-2738c998bb4d.png) ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No. Author: Sagar Kulkarni <sagarkulkarni3592@gmail.com> Closes #971 from sagarkulkarni3592/ZEPPELIN-961 and squashes the following commits: f7202c0 [Sagar Kulkarni] Merge branch 'master' of https://github.com/apache/incubator-zeppelin into ZEPPELIN-961 ff88f41 [Sagar Kulkarni] Made buttons position dynamic to size of name. a42045e [Sagar Kulkarni] Fixed the input box and button overlap. 9b29d8a [Sagar Kulkarni] Merge branch 'master' of https://github.com/apache/incubator-zeppelin into ZEPPELIN-961 37012ad [Sagar Kulkarni] Made adjustment to the name when window size is changed. 29607e5 [Sagar Kulkarni] ZEPPELIN-961 - Fixed the floating problem as well as styling of buttons. (cherry picked from commit 056eee8) Signed-off-by: Mina Lee <minalee@apache.org>
What is this PR for?
To correct the styling of notebook header which has notebook name, in case when the name is longer.
Feature : We should not limit the name size, but, while showing we can limit the name text to be shown.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
ZEPPELIN-961
How should this be tested?
Screenshots
Before bug fix :
After bug fix :
Questions: