ZOOKEEPER-4809: Fix do_completion use-after-free when log level is debug

The log callback needs to be obtained from freed zh when the log level is debug, resulting in used-after-free.
apache · Feb 20, 2024 · 9da7710 · 9da7710
1 parent 7074448
commit 9da7710
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/zookeeper-client/zookeeper-client-c/src/mt_adaptor.c b/zookeeper-client/zookeeper-client-c/src/mt_adaptor.c
@@ -479,8 +479,9 @@ void *do_completion(void *v)
         pthread_mutex_unlock(&zh->completions_to_process.lock);
         process_completions(zh);
     }
-    api_epilog(zh, 0);    
-    LOG_DEBUG(LOGCALLBACK(zh), "completion thread terminated");
+    log_callback_fn fn = LOGCALLBACK(zh);
+    api_epilog(zh, 0);
+    LOG_DEBUG(fn, "completion thread terminated");
     return 0;
 }