ZOOKEEPER-2383 #101
Closed
ZOOKEEPER-2383 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpj
reviewed
Dec 15, 2016
| public void run() { | ||
| try { | ||
| servcnxnf.startup(zks); | ||
| } catch (IOException | InterruptedException e) { |
There was a problem hiding this comment.
We can't have a multi-catch with Java 6, which is the earliest version we say we support in the docs.
There was a problem hiding this comment.
Thank you @fpj . I've separated out the catch block and done another commit in PR.
|
This is including the commit I just did for ZOOKEEPER-761, could you rebase your branch, please, @rakeshadr ? |
|
oops, I've rebased it and hope the PR is clean now. Please take a look at this when you get some time. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2016
Author: Rakesh Radhakrishnan <rakeshr@apache.org> Reviewers: fpj <fpj@apache.org>, rgs <rgs@apache.org>, hanm <hanm@apache.org> Closes #101 from rakeshadr/ZK-2383 and squashes the following commits: 4faa761 [Rakesh Radhakrishnan] ZOOKEEPER-2383: Startup race in ZooKeeperServer d2078d0 [Rakesh Radhakrishnan] ZOOKEEPER-2383
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
Author: Rakesh Radhakrishnan <rakeshr@apache.org> Reviewers: fpj <fpj@apache.org>, rgs <rgs@apache.org>, hanm <hanm@apache.org> Closes apache#101 from rakeshadr/ZK-2383 and squashes the following commits: 4faa761 [Rakesh Radhakrishnan] ZOOKEEPER-2383: Startup race in ZooKeeperServer d2078d0 [Rakesh Radhakrishnan] ZOOKEEPER-2383
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Author: Rakesh Radhakrishnan <rakeshr@apache.org> Reviewers: fpj <fpj@apache.org>, rgs <rgs@apache.org>, hanm <hanm@apache.org> Closes apache#101 from rakeshadr/ZK-2383 and squashes the following commits: 4faa761 [Rakesh Radhakrishnan] ZOOKEEPER-2383: Startup race in ZooKeeperServer d2078d0 [Rakesh Radhakrishnan] ZOOKEEPER-2383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.