ZOOKEEPER-3494 - remove unnecessary broad netty-all dependency #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest ant build |
tamaashu
approved these changes
Aug 5, 2019
|
Nice change. LGTM |
eolivelli
approved these changes
Aug 5, 2019
hanm
approved these changes
Aug 5, 2019
nkalmar
added a commit
to nkalmar/zookeeper
that referenced
this pull request
Aug 6, 2019
Currently netty-all is a 4MB dependency. Using netty-handler (429KB) and netty-transport-native-epoll (115KB) brings it down to about 1/8 in size. Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Tamás Pénzes, Michael Han <hanm@apache.org> Closes apache#1039 from nkalmar/ZK-3494
|
I think this should also get into 3.5, I created a new PR to verify the change (#1041), but it cherry-picks clean. |
asfgit
pushed a commit
that referenced
this pull request
Aug 6, 2019
Currently netty-all is a 4MB dependency. Using netty-handler (429KB) and netty-transport-native-epoll (115KB) brings it down to about 1/8 in size. Author: Norbert Kalmar <nkalmaryahoo.com> Reviewers: Enrico Olivelli <eolivelligmail.com>, Tamás Pénzes, Michael Han <hanmapache.org> Closes #1039 from nkalmar/ZK-3494 Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: andor@apache.org Closes #1041 from nkalmar/branch-3.5
|
In this PR netty-transport-native-epoll-4.1.42.Final.jar does not contain libnetty_transport_native_epoll_x86_64.so. May be should use <dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
<classifier>linux-x86_64</classifier>
<version>${netty.version}</version>
</dependency> |
|
You are totally right! |
stickyhipp
pushed a commit
to stickyhipp/zookeeper
that referenced
this pull request
Aug 19, 2020
Currently netty-all is a 4MB dependency. Using netty-handler (429KB) and netty-transport-native-epoll (115KB) brings it down to about 1/8 in size. Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Tamás Pénzes, Michael Han <hanm@apache.org> Closes apache#1039 from nkalmar/ZK-3494
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
Currently netty-all is a 4MB dependency. Using netty-handler (429KB) and netty-transport-native-epoll (115KB) brings it down to about 1/8 in size. Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Tamás Pénzes, Michael Han <hanm@apache.org> Closes apache#1039 from nkalmar/ZK-3494
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Currently netty-all is a 4MB dependency. Using netty-handler (429KB) and netty-transport-native-epoll (115KB) brings it down to about 1/8 in size. Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Tamás Pénzes, Michael Han <hanm@apache.org> Closes apache#1039 from nkalmar/ZK-3494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently netty-all is a 4MB dependency.
Using netty-handler (429KB) and netty-transport-native-epoll (115KB) brings it down to about 1/8 in size.