Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-3506:correct the javaDoc of the SessionTrackerImpl#initializeNextSessionId #1057

Closed
wants to merge 1 commit into from

Conversation

maoling
Copy link
Member

@maoling maoling commented Aug 19, 2019

  • A analyst of this method
    suppose that current timestamp:1566197268432(10110110010101000101000011011111111010000), myid=1
 00000000 00000000 00000001 01101100 10101000 10100001 10111111 11010000
<<24
 01101100 10101000 10100001 10111111 11010000 00000000 00000000 00000000
 >>>8
 00000000 01101100 10101000 10100001 10111111 11010000 00000000 00000000
|
 00000001 00000000 00000000 00000000 00000000 00000000 00000000 00000000(id << 56)
=
 00000001 01101100 10101000 10100001 10111111 11010000 00000000 00000000

Copy link
Contributor

@lvfangmin lvfangmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks @maoling!

@maoling
Copy link
Member Author

maoling commented Sep 20, 2019

ping @nkalmar or @eolivelli :)

Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 nice catch!

@asfgit asfgit closed this in 2c1034f Sep 20, 2019
@nkalmar
Copy link
Contributor

nkalmar commented Sep 20, 2019

Merged to master. Thanks @maoling !

@maoling maoling deleted the ZOOKEEPER-3506 branch September 20, 2019 09:09
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
…izeNextSessionId

- A analyst of this method
suppose that current timestamp:1566197268432(10110110010101000101000011011111111010000), myid=1

```
 00000000 00000000 00000001 01101100 10101000 10100001 10111111 11010000
<<24
 01101100 10101000 10100001 10111111 11010000 00000000 00000000 00000000
 >>>8
 00000000 01101100 10101000 10100001 10111111 11010000 00000000 00000000
|
 00000001 00000000 00000000 00000000 00000000 00000000 00000000 00000000(id << 56)
=
 00000001 01101100 10101000 10100001 10111111 11010000 00000000 00000000
```

- more details in the [ZOOKEEPER-3506](https://issues.apache.org/jira/browse/ZOOKEEPER-3506)

Author: maoling <maoling199210191@sina.com>

Reviewers: Allan Lyu <fangmin@apache.org>, Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org>

Closes apache#1057 from maoling/ZOOKEEPER-3506
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
…izeNextSessionId

- A analyst of this method
suppose that current timestamp:1566197268432(10110110010101000101000011011111111010000), myid=1

```
 00000000 00000000 00000001 01101100 10101000 10100001 10111111 11010000
<<24
 01101100 10101000 10100001 10111111 11010000 00000000 00000000 00000000
 >>>8
 00000000 01101100 10101000 10100001 10111111 11010000 00000000 00000000
|
 00000001 00000000 00000000 00000000 00000000 00000000 00000000 00000000(id << 56)
=
 00000001 01101100 10101000 10100001 10111111 11010000 00000000 00000000
```

- more details in the [ZOOKEEPER-3506](https://issues.apache.org/jira/browse/ZOOKEEPER-3506)

Author: maoling <maoling199210191@sina.com>

Reviewers: Allan Lyu <fangmin@apache.org>, Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org>

Closes apache#1057 from maoling/ZOOKEEPER-3506
@maoling maoling restored the ZOOKEEPER-3506 branch September 2, 2022 11:56
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
…izeNextSessionId

- A analyst of this method
suppose that current timestamp:1566197268432(10110110010101000101000011011111111010000), myid=1

```
 00000000 00000000 00000001 01101100 10101000 10100001 10111111 11010000
<<24
 01101100 10101000 10100001 10111111 11010000 00000000 00000000 00000000
 >>>8
 00000000 01101100 10101000 10100001 10111111 11010000 00000000 00000000
|
 00000001 00000000 00000000 00000000 00000000 00000000 00000000 00000000(id << 56)
=
 00000001 01101100 10101000 10100001 10111111 11010000 00000000 00000000
```

- more details in the [ZOOKEEPER-3506](https://issues.apache.org/jira/browse/ZOOKEEPER-3506)

Author: maoling <maoling199210191@sina.com>

Reviewers: Allan Lyu <fangmin@apache.org>, Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org>

Closes apache#1057 from maoling/ZOOKEEPER-3506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants