ZOOKEEPER-3539 Fix CI for branch-3.5: #1082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not execute findbugs on CI for ant-based tasks - fix usage of fprintf on C client
|
This PR achieves the goals:
|
|
This patch is only for branch-3.5, master branch is using only Spotbugs and C client does not suffer of that issue |
|
retest ant build |
nkalmar
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
+1, removing/unlinking findbugs on 3.5 is fine, we agreed to keep supporting both ant and maven on 3.5 if I remember correctly. Since findbugs is no longer supported by ASF Jenkins job, this is the way to go. Thanks @eolivelli !
|
@nkalmar can you please merge this patch? |
asfgit
pushed a commit
that referenced
this pull request
Sep 9, 2019
- do not execute findbugs on CI for ant-based tasks - fix usage of fprintf on C client Maven + Spotbugs superseded Ant + Findbugs Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org> Closes #1082 from eolivelli/fix/fix-ci-35
|
Pushed to 3.5. Thanks @eolivelli |
anmolnar
pushed a commit
to anmolnar/zookeeper
that referenced
this pull request
Nov 28, 2019
- do not execute findbugs on CI for ant-based tasks - fix usage of fprintf on C client Maven + Spotbugs superseded Ant + Findbugs Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org> Closes apache#1082 from eolivelli/fix/fix-ci-35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven + Spotbugs superseded Ant + Findbugs