Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-3411 Remove deprecated ls2 and rmr command #1175

Closed
wants to merge 1 commit into from

Conversation

rabi-kumar
Copy link
Contributor

Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java.

Please do let me know if any additional changes are needed

@asf-ci
Copy link

asf-ci commented Dec 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/1712/

Copy link
Member

@maoling maoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@rabi-kumar
Copy link
Contributor Author

@eolivelli calling for review.

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 27b92ca Jan 9, 2020
asfgit pushed a commit that referenced this pull request Jan 9, 2020
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java.

Please do let me know if any additional changes are needed

Author: ravowlga123 <ravowlga@gmail.com>

Reviewers: andor@apache.org

Closes #1175 from ravowlga123/ZOOKEEPER-3411

(cherry picked from commit 27b92ca)
Signed-off-by: Andor Molnar <andor@apache.org>
@anmolnar
Copy link
Contributor

anmolnar commented Jan 9, 2020

Merged to master and 3.6 branches. Thanks @ravowlga123 !
Please pick up this Jira too. If you don't have the required permissions, please let me know your Jira username.

@eolivelli I was not sure about 3.6, but ended up cherry picking. Please let me know if you feel otherwise.

@eolivelli
Copy link
Contributor

@anmolnar ok for this patch.
Please do not commit other patches to branch-3.6.
I am trying current revision.
As soon as I am confident I will create the tag and call for a vote.
Thanks for tagging me

@rabi-kumar
Copy link
Contributor Author

rabi-kumar commented Jan 10, 2020

Hi @anmolnar I actually don't have required permissions to assign tickets to myself.

  • Jira ID: rabikumar.kc

I also sent an email to the dev mailing list.

junyoungKimGit pushed a commit to junyoungKimGit/zookeeper that referenced this pull request Feb 7, 2020
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java.

Please do let me know if any additional changes are needed

Author: ravowlga123 <ravowlga@gmail.com>

Reviewers: andor@apache.org

Closes apache#1175 from ravowlga123/ZOOKEEPER-3411
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java.

Please do let me know if any additional changes are needed

Author: ravowlga123 <ravowlga@gmail.com>

Reviewers: andor@apache.org

Closes apache#1175 from ravowlga123/ZOOKEEPER-3411
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java.

Please do let me know if any additional changes are needed

Author: ravowlga123 <ravowlga@gmail.com>

Reviewers: andor@apache.org

Closes apache#1175 from ravowlga123/ZOOKEEPER-3411
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java.

Please do let me know if any additional changes are needed

Author: ravowlga123 <ravowlga@gmail.com>

Reviewers: andor@apache.org

Closes apache#1175 from ravowlga123/ZOOKEEPER-3411
tisonkun added a commit to tisonkun/zookeeper that referenced this pull request May 24, 2023
This is a follow-up to apache#1175.

Signed-off-by: tison <wander4096@gmail.com>
tisonkun added a commit that referenced this pull request Jun 13, 2023
…#2000)

This is a follow-up to #1175.

Signed-off-by: tison <wander4096@gmail.com>
anurag-harness pushed a commit to anurag-harness/zookeeper that referenced this pull request Aug 31, 2023
…apache#2000)

This is a follow-up to apache#1175.

Signed-off-by: tison <wander4096@gmail.com>
anurag-harness added a commit to anurag-harness/zookeeper that referenced this pull request Aug 31, 2023
…apache#2000) (#50)

This is a follow-up to apache#1175.

Signed-off-by: tison <wander4096@gmail.com>
Co-authored-by: tison <wander4096@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants