-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZOOKEEPER-3411 Remove deprecated ls2 and rmr command #1175
Conversation
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
@eolivelli calling for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java. Please do let me know if any additional changes are needed Author: ravowlga123 <ravowlga@gmail.com> Reviewers: andor@apache.org Closes #1175 from ravowlga123/ZOOKEEPER-3411 (cherry picked from commit 27b92ca) Signed-off-by: Andor Molnar <andor@apache.org>
Merged to master and 3.6 branches. Thanks @ravowlga123 ! @eolivelli I was not sure about 3.6, but ended up cherry picking. Please let me know if you feel otherwise. |
@anmolnar ok for this patch. |
Hi @anmolnar I actually don't have required permissions to assign tickets to myself.
I also sent an email to the dev mailing list. |
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java. Please do let me know if any additional changes are needed Author: ravowlga123 <ravowlga@gmail.com> Reviewers: andor@apache.org Closes apache#1175 from ravowlga123/ZOOKEEPER-3411
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java. Please do let me know if any additional changes are needed Author: ravowlga123 <ravowlga@gmail.com> Reviewers: andor@apache.org Closes apache#1175 from ravowlga123/ZOOKEEPER-3411
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java. Please do let me know if any additional changes are needed Author: ravowlga123 <ravowlga@gmail.com> Reviewers: andor@apache.org Closes apache#1175 from ravowlga123/ZOOKEEPER-3411
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java. Please do let me know if any additional changes are needed Author: ravowlga123 <ravowlga@gmail.com> Reviewers: andor@apache.org Closes apache#1175 from ravowlga123/ZOOKEEPER-3411
This is a follow-up to apache#1175. Signed-off-by: tison <wander4096@gmail.com>
…apache#2000) This is a follow-up to apache#1175. Signed-off-by: tison <wander4096@gmail.com>
…apache#2000) (#50) This is a follow-up to apache#1175. Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: tison <wander4096@gmail.com>
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java.
Please do let me know if any additional changes are needed