ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2

[eolivelli]

• upgrade to Apache Parent 23
• disable maven remote plugin
• move source assembly execution before sources generation
• move git properties resolution to the correct phase

[eolivelli]

@anmolnar @nkalmar I need a little help merging this patch.
Please cherry pick to branch-3.6 and release-3.6.0

I saw that the source release tarball still does not reflect perfectly the repository

in order to build the tarball the command is:
mvn clean install -DskipTests -Pfull-build -Papache-release

a shortcut is to add '-N' (non recursive) in order to build only the top level project
mvn clean install -DskipTests -Pfull-build -Papache-release -N

remember to issue a "git clean -xfd" in order to have a clean git repository

I feel that zookeeper-server/src/main/resources/git.properties is in the wrong place, it is a generated resource and it should stay in zookeeper-server/target/generated-resources/git.properties or something like that.
btw This patch does not address this issue, and the package is built correctly only if you start with a clean git repository

[eolivelli]

current master build is broken.
The patch applies cleanly to branch 3.6 without problem

[eolivelli]

retest this please

[eolivelli]

PR #1239 has been fixed, now this branch is good for merge.
Let's wait CI

[nkalmar]

LGTM. None of the differences fixed with this and last part of the PR concerns 3.5 branch?

[eolivelli]

Maybe we can just do the change about disabling the remote resources plugin.
Nothing more

Did you have time to test this patch locally? This way we can save time and prevent -1s during the VOTE