ZOOKEEPER-3722: make logs of ResponseCache more readable #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HorizonNet
approved these changes
Feb 18, 2020
hanm
reviewed
May 28, 2020
|
|
||
| getChildrenResponseCache = new ResponseCache(Integer.getInteger( | ||
| GET_CHILDREN_RESPONSE_CACHE_SIZE, | ||
| ResponseCache.DEFAULT_RESPONSE_CACHE_SIZE)); | ||
| ResponseCache.DEFAULT_RESPONSE_CACHE_SIZE), "getChild"); |
There was a problem hiding this comment.
let's replace "getChild" with "getChildren" so it's consistent with the op code and the cache name getChildrenResponseCache.
There was a problem hiding this comment.
replaced "getChild" with "getChildren".
hanm
approved these changes
Oct 20, 2020
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
As per [ZOOKEEPER-3722](https://issues.apache.org/jira/browse/ZOOKEEPER-3722), we need to make ResponseCache logs more readable by adding the request type to the logs. For this I made the following changes: - Added a parameter named requestType to ResponseCache constructor. - Passed requestType as getData and getChild when the constructor is called to initialize readResponseCache and getChildrenResponseCache respectively. Please let me know if additional changes are required. Author: Nishanth Entoor <entoor.nishanth@gmail.com> Reviewers: hanm, HorizonNet, maoling Closes apache#1253 from nishanth-entoor/ZOOKEEPER-3722
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
As per [ZOOKEEPER-3722](https://issues.apache.org/jira/browse/ZOOKEEPER-3722), we need to make ResponseCache logs more readable by adding the request type to the logs. For this I made the following changes: - Added a parameter named requestType to ResponseCache constructor. - Passed requestType as getData and getChild when the constructor is called to initialize readResponseCache and getChildrenResponseCache respectively. Please let me know if additional changes are required. Author: Nishanth Entoor <entoor.nishanth@gmail.com> Reviewers: hanm, HorizonNet, maoling Closes apache#1253 from nishanth-entoor/ZOOKEEPER-3722
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
As per [ZOOKEEPER-3722](https://issues.apache.org/jira/browse/ZOOKEEPER-3722), we need to make ResponseCache logs more readable by adding the request type to the logs. For this I made the following changes: - Added a parameter named requestType to ResponseCache constructor. - Passed requestType as getData and getChild when the constructor is called to initialize readResponseCache and getChildrenResponseCache respectively. Please let me know if additional changes are required. Author: Nishanth Entoor <entoor.nishanth@gmail.com> Reviewers: hanm, HorizonNet, maoling Closes apache#1253 from nishanth-entoor/ZOOKEEPER-3722
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
As per [ZOOKEEPER-3722](https://issues.apache.org/jira/browse/ZOOKEEPER-3722), we need to make ResponseCache logs more readable by adding the request type to the logs. For this I made the following changes: - Added a parameter named requestType to ResponseCache constructor. - Passed requestType as getData and getChild when the constructor is called to initialize readResponseCache and getChildrenResponseCache respectively. Please let me know if additional changes are required. Author: Nishanth Entoor <entoor.nishanth@gmail.com> Reviewers: hanm, HorizonNet, maoling Closes apache#1253 from nishanth-entoor/ZOOKEEPER-3722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per ZOOKEEPER-3722, we need to make ResponseCache logs more readable by adding the request type to the logs. For this I made the following changes:
Please let me know if additional changes are required.