[ZOOKEEPER-3655] Remove localhost hardcoding from QuorumSSLTest on master #1272
+70
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symat
requested changes
Mar 2, 2020
| private static String HOSTNAME; | ||
| private static String ipAddress; | ||
|
|
||
| { |
There was a problem hiding this comment.
is there a benefit using a static variable plus this initializer block? I would maybe prefer simply setting non-static ipAddress ad hostname in the setup() method we have already below. I think the later would be a bit nicer.
If you decide to stick with the static variables, then please use capital letters (e.g. IP_ADDRESS) to match the other static variables.
| HOSTNAME = address.getHostName(); | ||
| ipAddress = address.getHostAddress(); | ||
| } catch (UnknownHostException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
please use a logger to log exceptions.
|
It looks the test class is actually fails now on Jenkins: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/1883/testReport/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested on #1188, creating corresponding PR for master.