Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3763 Restore ZKUtil.deleteRecursive in order to help compatibility of applications with 3.5 and 3.6 #1287

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-3763 Restore ZKUtil.deleteRecursive in order to help compatibility of applications with 3.5 and 3.6 #1287

wants to merge 1 commit into from

Conversation

eolivelli
Copy link
Contributor

No description provided.

ctubbsii
ctubbsii approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea to me, although I don't know if the batch size of 1000 is best or if another number would be better.

@eolivelli
Copy link
Contributor Author

@nkalmar this is a good candidate for 3.6.1

please take a look

nkalmar
nkalmar approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@nkalmar nkalmar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, batchsize of 1000 I guess is as good as any other value. A lot depends on znode depts/size and whatnot. As this is for backward compatibility, I think were fine with 1000.

@eolivelli
Copy link
Contributor Author

@nkalmar can you now help merging this patch ?

@eolivelli eolivelli closed this in bb80b81 Mar 22, 2020
eolivelli pushed a commit that referenced this pull request Mar 22, 2020
ZOOKEEPER-3763: Restore ZKUtil.deleteRecursive in order to help compa…
001ed3b 
…tibility of applications with 3.5 and 3.6

Author: Enrico Olivelli <enrico.olivelli@diennea.com>

Reviewers: Christopher Tubbs, Norbert Kalmar <nkalmar@apache.org>, Mate Szalay-Beko

Closes #1287 from eolivelli/fix/ZOOKEEPER-3763-compat

(cherry picked from commit bb80b81)
Signed-off-by: Enrico Olivelli <enrico.olivelli@diennea.com>
@eolivelli
Copy link
Contributor Author

I have merged this patch and deployed SNAPSHOTs in order to easily test downstream projects, like BooKeeper

This was referenced Mar 22, 2020
Merged
Closed
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
@stickyhipp
ZOOKEEPER-3763: Restore ZKUtil.deleteRecursive in order to help compa…
4bad684 
…tibility of applications with 3.5 and 3.6

Author: Enrico Olivelli <enrico.olivelli@diennea.com>

Reviewers: Christopher Tubbs, Norbert Kalmar <nkalmar@apache.org>, Mate Szalay-Beko

Closes apache#1287 from eolivelli/fix/ZOOKEEPER-3763-compat
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@RokLenarcic
ZOOKEEPER-3763: Restore ZKUtil.deleteRecursive in order to help compa…
7fb95c4 
…tibility of applications with 3.5 and 3.6

Author: Enrico Olivelli <enrico.olivelli@diennea.com>

Reviewers: Christopher Tubbs, Norbert Kalmar <nkalmar@apache.org>, Mate Szalay-Beko

Closes apache#1287 from eolivelli/fix/ZOOKEEPER-3763-compat
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@RokLenarcic
ZOOKEEPER-3763: Restore ZKUtil.deleteRecursive in order to help compa…
bf9dd3a 
…tibility of applications with 3.5 and 3.6

Author: Enrico Olivelli <enrico.olivelli@diennea.com>

Reviewers: Christopher Tubbs, Norbert Kalmar <nkalmar@apache.org>, Mate Szalay-Beko

Closes apache#1287 from eolivelli/fix/ZOOKEEPER-3763-compat
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@RokLenarcic
ZOOKEEPER-3763: Restore ZKUtil.deleteRecursive in order to help compa…
64cd90e 
…tibility of applications with 3.5 and 3.6

Author: Enrico Olivelli <enrico.olivelli@diennea.com>

Reviewers: Christopher Tubbs, Norbert Kalmar <nkalmar@apache.org>, Mate Szalay-Beko

Closes apache#1287 from eolivelli/fix/ZOOKEEPER-3763-compat
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@RokLenarcic
ZOOKEEPER-3763: Restore ZKUtil.deleteRecursive in order to help compa…
d8bb52e 
…tibility of applications with 3.5 and 3.6

Author: Enrico Olivelli <enrico.olivelli@diennea.com>

Reviewers: Christopher Tubbs, Norbert Kalmar <nkalmar@apache.org>, Mate Szalay-Beko

Closes apache#1287 from eolivelli/fix/ZOOKEEPER-3763-compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctubbsii ctubbsii ctubbsii approved these changes

@nkalmar nkalmar nkalmar approved these changes

@symat symat symat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@eolivelli @ctubbsii @nkalmar @symat