Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-3802: Fix rat checks in full-build and fatjar #1326

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-3802: Fix rat checks in full-build and fatjar #1326

wants to merge 1 commit into from

Commits on Apr 19, 2020

  1. ZOOKEEPER-3802: Fix rat checks in full-build and fatjar

    Ensure apache-rat:check passes with and without -Pfull-build and/or -Pfatjar
    
    Specifically, this change does:
    
    1. Use wildcards for rat check excludes, so the build passes whether rat
       detects the fils at the build execution root or within the activated
       module, so the rat check works whether or not the full-build or
       fatjar profiles are activated.
    2. Ensures properties set at zookeeper-contrib that control rat,
       spotbugs, and checkstyle, are properly passed down to the contrib
       submodules when fatjar is activated, by ensuring the intermediate
       parent pom for zookeeper-contrib is activated when any of its
       submodules are activated.
    3. Also use version of spotbugs that works with newer JDKs so the full
       build, including rat checks, can be tested with newer JDKs.
    ctubbsii committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    9a925b6 View commit details
    Browse the repository at this point in the history