ZOOKEEPER-3739 Remove use of com.sun.nio.file.SensitivityWatchEventModifier #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier to better support builds against newer JDKs. Also update build tooling to use strict JDK release compatibility when building with newer JDKs by adding profiles which automatically activate the correct compiler flag when the newer JDK is detected when building with Maven or Eclipse. Author: Christopher Tubbs <ctubbsii@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org> Closes apache#1269 from ctubbsii/ZK-3739
eolivelli
approved these changes
Apr 28, 2020
|
LGTM +1 |
symat
approved these changes
Apr 28, 2020
ctubbsii
approved these changes
Apr 28, 2020
|
I'll merge it now |
eolivelli
approved these changes
Apr 28, 2020
asfgit
pushed a commit
that referenced
this pull request
Apr 28, 2020
…odifier 3.5 backport of #1269 Author: Christopher Tubbs <ctubbsii@apache.org> Reviewers: Andor Molnar <andor@apache.org>, Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes #1340 from anmolnar/ZOOKEEPER-3215_35
|
merged to branch-3.5. I also added the 3.5.8 tag to the original Jira. Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.5 backport of #1269