ZOOKEEPER-3751: upgrade jackson-databind to 2.10 from 2.9 #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original PR (apache#1283) was only merged to 3.6+, as in 3.5 we also have to change the ant configs. I created a new PR to kick-in the CI also for branch 3.5.
|
I executed the admin server related unit tests and also tested manually the admin server with Chrome and with curl. Everything seemed to be fine. |
|
applying this patch on branch-3.5 makes "mvn clean package -DskipTests dependency-check:check" to run successfully |
|
retest ant build |
eolivelli
approved these changes
Apr 28, 2020
|
retest ant build |
ctubbsii
reviewed
Apr 28, 2020
|
We only upgrade this to fix some CVEs on branch-3.5. I am not familiar with jackson, but maybe a more mature 2.10.3 is safer in terms of future CVEs than the first 2.11 release would be. But I am happy to do an other upgrade later, if it would be needed. I'll merge this PR now to branch 3.5. |
asfgit
pushed a commit
that referenced
this pull request
Apr 30, 2020
The original PR (#1283) was only merged to 3.6+ as in 3.5 we also have to change the ant configs. I created a new PR to kick-in the CI also for branch 3.5. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes #1341 from symat/ZOOKEEPER-3751-branch-3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR (#1283) was only merged to 3.6+ as in 3.5 we also have to change the ant configs. I created a new PR to kick-in the CI also for branch 3.5.