ZOOKEEPER-3832 ZKHostnameVerifier rejects valid certificates with subjectAltNames (3.5) #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bjectAltNames This issue has been reported by a user who wanted to use a cert that contains SAN entries that are not of type DNS or IP. I've come across the following ticket in http client project which seems to be related: https://issues.apache.org/jira/browse/HTTPCLIENT-1906 This is the backport of the fix. Original patch: apache/httpcomponents-client@56cc245 Target versions: 3.5, 3.6, 3.7 Author: Andor Molnar <andor@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1353 from anmolnar/ZOOKEEPER-3832
symat
approved these changes
May 21, 2020
|
Please merge. I can't do it now |
|
I'll merge it now |
asfgit
pushed a commit
that referenced
this pull request
May 21, 2020
…bjectAltNames (3.5) Backport to 3.5 This issue has been reported by a user who wanted to use a cert that contains SAN entries that are not of type DNS or IP. I've come across the following ticket in http client project which seems to be related: https://issues.apache.org/jira/browse/HTTPCLIENT-1906 This is the backport of the fix. Original patch: apache/httpcomponents-client@56cc245 Target versions: 3.5, 3.6, 3.7 Author: Andor Molnar <andorapache.org> Reviewers: Enrico Olivelli <eolivelliapache.org>, Mate Szalay-Beko <symatapache.org> Closes #1364 from anmolnar/ZOOKEEPER-3832_35
|
merge done, I also updated the "fixed versions" on the Jira ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to 3.5
This issue has been reported by a user who wanted to use a cert that contains SAN entries that are not of type DNS or IP.
I've come across the following ticket in http client project which seems to be related:
https://issues.apache.org/jira/browse/HTTPCLIENT-1906
This is the backport of the fix.
Original patch: apache/httpcomponents-client@56cc245
Target versions: 3.5, 3.6, 3.7
Author: Andor Molnar andor@apache.org
Reviewers: Enrico Olivelli eolivelli@apache.org, Mate Szalay-Beko symat@apache.org
Closes #1353 from anmolnar/ZOOKEEPER-3832