Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3913: Upgrade to Netty 4.1.50.Final #1428

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-3913: Upgrade to Netty 4.1.50.Final #1428

wants to merge 1 commit into from

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Aug 10, 2020

  • Upgrade Netty to its latest version 4.1.50.Final which includes both security fixes and AArch64 performance improvements
    Refer release notes for detail: https://netty.io/news/2020/05/13/4-1-50-Final.html
  • Upgraded surefire to 3.0.0-M5 due to compatibility

@odidev
Copy link
Contributor Author

odidev commented Aug 13, 2020

Hi,
Please have a look at this PR.

eolivelli
eolivelli approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not upgrade surefire if not needed.

Can you please also log a JIRA issue?
This will help us in preparing the release notes and keep track of this update in the future

Thank you very much

@odidev odidev changed the title Upgrade to Netty 4.1.50.Final ZOOKEEPER-3913: Upgrade to Netty 4.1.50.Final Aug 17, 2020
@odidev
ZOOKEEPER-3913:Upgrade netty to 4.1.50.Final
d5a9087 
-Update netty 4.1.50 which includes both security fixes and AArch64 performance improvements
@odidev
Copy link
Contributor Author

odidev commented Aug 17, 2020

@eolivelli,
Incorporated comments in the PR and raised JIRA : "https://issues.apache.org/jira/browse/ZOOKEEPER-3913"
Please have a look.

@eolivelli
Copy link
Contributor

LGTM

Tagging @symat @anmolnar

symat
symat approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@symat symat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I see also the CI is happy (only one intermittent test failed)

@symat
Copy link
Contributor

symat commented Aug 20, 2020

@eolivelli sorry, I'm on vacation, can not merge it right now.

@eolivelli
Copy link
Contributor

@symat the same for me :)

There is no hurry

eolivelli pushed a commit that referenced this pull request Aug 21, 2020
@odidev @eolivelli
ZOOKEEPER-3913: Upgrade to Netty 4.1.50.Final
ec272f3 
- Upgrade Netty to its latest version 4.1.50.Final which includes both security fixes and AArch64 performance improvements
Refer release notes for detail: https://netty.io/news/2020/05/13/4-1-50-Final.html
- Upgraded surefire to 3.0.0-M5 due to compatibility

Author: odidev <odidev@puresoftware.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes #1428 from odidev/netty_upgrade

(cherry picked from commit e16361d)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
@eolivelli eolivelli closed this in e16361d Aug 21, 2020
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@odidev @RokLenarcic
ZOOKEEPER-3913: Upgrade to Netty 4.1.50.Final
58700c8 
- Upgrade Netty to its latest version 4.1.50.Final which includes both security fixes and AArch64 performance improvements
Refer release notes for detail: https://netty.io/news/2020/05/13/4-1-50-Final.html
- Upgraded surefire to 3.0.0-M5 due to compatibility

Author: odidev <odidev@puresoftware.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1428 from odidev/netty_upgrade
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@odidev @RokLenarcic
ZOOKEEPER-3913: Upgrade to Netty 4.1.50.Final
00e85ec 
- Upgrade Netty to its latest version 4.1.50.Final which includes both security fixes and AArch64 performance improvements
Refer release notes for detail: https://netty.io/news/2020/05/13/4-1-50-Final.html
- Upgraded surefire to 3.0.0-M5 due to compatibility

Author: odidev <odidev@puresoftware.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1428 from odidev/netty_upgrade
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@odidev @RokLenarcic
ZOOKEEPER-3913: Upgrade to Netty 4.1.50.Final
1d8d91e 
- Upgrade Netty to its latest version 4.1.50.Final which includes both security fixes and AArch64 performance improvements
Refer release notes for detail: https://netty.io/news/2020/05/13/4-1-50-Final.html
- Upgraded surefire to 3.0.0-M5 due to compatibility

Author: odidev <odidev@puresoftware.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1428 from odidev/netty_upgrade
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@odidev @RokLenarcic
ZOOKEEPER-3913: Upgrade to Netty 4.1.50.Final
2e457b7 
- Upgrade Netty to its latest version 4.1.50.Final which includes both security fixes and AArch64 performance improvements
Refer release notes for detail: https://netty.io/news/2020/05/13/4-1-50-Final.html
- Upgraded surefire to 3.0.0-M5 due to compatibility

Author: odidev <odidev@puresoftware.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1428 from odidev/netty_upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@symat symat symat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@odidev @eolivelli @symat