Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3941: Upgrade commons-cli to 1.4 #1463

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-3941: Upgrade commons-cli to 1.4 #1463

wants to merge 1 commit into from

Conversation

tamaashu
Copy link
Contributor

@tamaashu tamaashu commented Sep 22, 2020 •
edited by symat
Loading

commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4).
To avoid deprecation messages we have to upgrade the Java code too.

@tamaashu
ZOOKEEPER-3941: Upgrade commons-cli to 1.4
b98f53d 
commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4).
To avoid deprecation messages we have to upgrade the Java code too.

Change-Id: I127bc597556de2cb3dcc8336a383cdbf15be3639
symat
symat approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@symat symat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

For the master branch I see no risk in merging this. However, for the branch-3.5 and branch-3.6 I would not recommend this, unless there is some CVE about the old commons-cli and/or we are absolutely certain that the CLI works exactly the same way as before. (CLI commands can be hardcoded in our users' infrastructure code and I would rather not change ZK behaviour in any bugfix release)

What do you think?

@symat
Copy link
Contributor

symat commented Sep 23, 2020

(please avoid gerrit "Change-Id" in the description. The PR's description will be used as the final commit message, and gerrit change id has no meaning in our apache CI / review process)

eolivelli
eolivelli approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@symat feel free to commit.

For the record: Commons CLI is from the ASF and we are not bundling a separate "LICENSE" file, this is to be checked for every dependency upgrade

@asfgit asfgit closed this in 492fd79 Sep 23, 2020
@symat
Copy link
Contributor

symat commented Sep 23, 2020

merged to the master branch, thanks for the contribution @tamaashu!

For the record: Commons CLI is from the ASF and we are not bundling a separate "LICENSE" file, this is to be checked for every dependency upgrade

@eolivelli thanks for pointing this out, I'll make sure to check this next time! thanks for the review!

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@tamaashu @RokLenarcic
ZOOKEEPER-3941: Upgrade commons-cli to 1.4
1f9c023 
commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4).
To avoid deprecation messages we have to upgrade the Java code too.

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1463 from tamaashu/zookeeper-3941
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@tamaashu @RokLenarcic
ZOOKEEPER-3941: Upgrade commons-cli to 1.4
97eff36 
commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4).
To avoid deprecation messages we have to upgrade the Java code too.

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1463 from tamaashu/zookeeper-3941
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@tamaashu @RokLenarcic
ZOOKEEPER-3941: Upgrade commons-cli to 1.4
76e5a1c 
commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4).
To avoid deprecation messages we have to upgrade the Java code too.

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1463 from tamaashu/zookeeper-3941
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@tamaashu @RokLenarcic
ZOOKEEPER-3941: Upgrade commons-cli to 1.4
1c61e80 
commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4).
To avoid deprecation messages we have to upgrade the Java code too.

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1463 from tamaashu/zookeeper-3941
symat pushed a commit to symat/zookeeper that referenced this pull request Dec 8, 2022
@tamaashu
ZOOKEEPER-3941: Upgrade commons-cli to 1.4
7143df7 
commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4).
To avoid deprecation messages we have to upgrade the Java code too.

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1463 from tamaashu/zookeeper-3941

(cherry picked from commit 492fd79)
@symat symat mentioned this pull request Dec 8, 2022
Merged
asfgit pushed a commit that referenced this pull request Dec 9, 2022
@tamaashu
ZOOKEEPER-3941: Upgrade commons-cli to 1.4
98bde18 
commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4). To avoid deprecation messages we have to upgrade the Java code too.

Author: Tamas Penzes <tamaascloudera.com>

Reviewers: Enrico Olivelli <eolivelliapache.org>, Mate Szalay-Beko <symatapache.org>

Closes #1463 from tamaashu/zookeeper-3941

(cherry picked from commit 492fd79)

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Andor Molnar <andor@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes #1954 from symat/ZOOKEEPER-3941-branch-3.6
desaikomal pushed a commit to linkedin/zookeeper that referenced this pull request Jun 17, 2023
@tamaashu @desaikomal
ZOOKEEPER-3941: Upgrade commons-cli to 1.4
74c20b1 
commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4). To avoid deprecation messages we have to upgrade the Java code too.

Author: Tamas Penzes <tamaascloudera.com>

Reviewers: Enrico Olivelli <eolivelliapache.org>, Mate Szalay-Beko <symatapache.org>

Closes apache#1463 from tamaashu/zookeeper-3941

(cherry picked from commit 492fd79)

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Andor Molnar <andor@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1954 from symat/ZOOKEEPER-3941-branch-3.6
desaikomal pushed a commit to linkedin/zookeeper that referenced this pull request Jun 27, 2023
@tamaashu @desaikomal
ZOOKEEPER-3941: Upgrade commons-cli to 1.4
dd47d7a 
commons-cli 1.2 was released in 2009, time to upgrade it to the newest version (1.4). To avoid deprecation messages we have to upgrade the Java code too.

Author: Tamas Penzes <tamaascloudera.com>

Reviewers: Enrico Olivelli <eolivelliapache.org>, Mate Szalay-Beko <symatapache.org>

Closes apache#1463 from tamaashu/zookeeper-3941

(cherry picked from commit 492fd79)

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Andor Molnar <andor@apache.org>, Mate Szalay-Beko <symat@apache.org>

Closes apache#1954 from symat/ZOOKEEPER-3941-branch-3.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@symat symat symat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tamaashu @symat @eolivelli