Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-3953: Update hamcrest-library to version 2.2 #1479

Closed
wants to merge 1 commit into from

Conversation

tamaashu
Copy link
Contributor

@tamaashu tamaashu commented Oct 3, 2020

We use a really old version of hamcrest-library where we could use a newer one (version 2.2 instead of 1.3).
Time to update it.

We use a really old version of hamcrest-library where we could use a newer one (version 2.2 instead of 1.3).
Time to update it.

Change-Id: I8d3d76b1b287610b58d4760a87428c41b43ef091
Copy link
Member

@maoling maoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds are green, LGTM.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 663081d Oct 5, 2020
@nkalmar
Copy link
Contributor

nkalmar commented Oct 5, 2020

Merged to master, thanks @tamaashu

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
We use a really old version of hamcrest-library where we could use a newer one (version 2.2 instead of 1.3).
Time to update it.

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org>

Closes apache#1479 from tamaashu/ZOOKEEPER-3953
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
We use a really old version of hamcrest-library where we could use a newer one (version 2.2 instead of 1.3).
Time to update it.

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org>

Closes apache#1479 from tamaashu/ZOOKEEPER-3953
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
We use a really old version of hamcrest-library where we could use a newer one (version 2.2 instead of 1.3).
Time to update it.

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org>

Closes apache#1479 from tamaashu/ZOOKEEPER-3953
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
We use a really old version of hamcrest-library where we could use a newer one (version 2.2 instead of 1.3).
Time to update it.

Author: Tamas Penzes <tamaas@cloudera.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org>

Closes apache#1479 from tamaashu/ZOOKEEPER-3953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants