Commits on Oct 6, 2020

1. ZOOKEEPER-3954: C client: Avoid compilation issue with aggressive inl… …

   …ining
   
   Michael Hudson-Doyle experienced an error while compiling the C client
   with GCC 10 and aggressive optimization settings:
   
   > `free_auth_completions` is being inlined into `free_completions`,
   > and this lets gcc see that members of `a_list` are being accessed
   > without initialization
   
   This is (fortunately!) a red herring: what GCC doesn't see is that, in
   practice, `zoo_lock_auth` always returns zero, and that `a_list` is
   always initialized in the conditional block which follows it.
   
   Let's "fix" this by removing the `if`.  The rest of the client code
   doesn't check `zoo_lock_auth`'s return value--and we have bigger
   issues if unconditional locks start failing anyway.

   

   ztzg committed Oct 6, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 9f87663
   • Browse repository at this point

   Copy the full SHA

   9f87663 View commit details

   Browse the repository at this point in the history