ZOOKEEPER-3981: Flaky test MultipleAddressTest::testGetValidAddressWithNotValid #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
reviewed
Oct 21, 2020
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/MultipleAddressesTest.java
Outdated
Show resolved
Hide resolved
…rum/MultipleAddressesTest.java Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
ctubbsii
approved these changes
Oct 24, 2020
asfgit
pushed a commit
that referenced
this pull request
Oct 24, 2020
…thNotValid Problem: Test MultipleAddressTest::testGetValidAddressWithNotValid might fail deterministically when the address it's using, 10.0.0.1, is reachable, as per https://tools.ietf.org/html/rfc5735 10.0.0.1 might be allocatable to private network usage. In fact, the router address of my ISP is assigned this IP, leading to this test always failing for me. Solution: Replace the address with 240.0.0.0, which is reserved for future use and less likely to be reachable. Author: Michael Han <michael@lianghan.org> Author: Michael Han <hanm@apache.org> Reviewers: Christopher Tubbs <ctubbsii@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes #1511 from hanm/fixut (cherry picked from commit 3ff30a6) Signed-off-by: Mate Szalay-Beko <symat@apache.org>
|
Thank you! |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…thNotValid Problem: Test MultipleAddressTest::testGetValidAddressWithNotValid might fail deterministically when the address it's using, 10.0.0.1, is reachable, as per https://tools.ietf.org/html/rfc5735 10.0.0.1 might be allocatable to private network usage. In fact, the router address of my ISP is assigned this IP, leading to this test always failing for me. Solution: Replace the address with 240.0.0.0, which is reserved for future use and less likely to be reachable. Author: Michael Han <michael@lianghan.org> Author: Michael Han <hanm@apache.org> Reviewers: Christopher Tubbs <ctubbsii@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1511 from hanm/fixut
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…thNotValid Problem: Test MultipleAddressTest::testGetValidAddressWithNotValid might fail deterministically when the address it's using, 10.0.0.1, is reachable, as per https://tools.ietf.org/html/rfc5735 10.0.0.1 might be allocatable to private network usage. In fact, the router address of my ISP is assigned this IP, leading to this test always failing for me. Solution: Replace the address with 240.0.0.0, which is reserved for future use and less likely to be reachable. Author: Michael Han <michael@lianghan.org> Author: Michael Han <hanm@apache.org> Reviewers: Christopher Tubbs <ctubbsii@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1511 from hanm/fixut
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…thNotValid Problem: Test MultipleAddressTest::testGetValidAddressWithNotValid might fail deterministically when the address it's using, 10.0.0.1, is reachable, as per https://tools.ietf.org/html/rfc5735 10.0.0.1 might be allocatable to private network usage. In fact, the router address of my ISP is assigned this IP, leading to this test always failing for me. Solution: Replace the address with 240.0.0.0, which is reserved for future use and less likely to be reachable. Author: Michael Han <michael@lianghan.org> Author: Michael Han <hanm@apache.org> Reviewers: Christopher Tubbs <ctubbsii@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1511 from hanm/fixut
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
…thNotValid Problem: Test MultipleAddressTest::testGetValidAddressWithNotValid might fail deterministically when the address it's using, 10.0.0.1, is reachable, as per https://tools.ietf.org/html/rfc5735 10.0.0.1 might be allocatable to private network usage. In fact, the router address of my ISP is assigned this IP, leading to this test always failing for me. Solution: Replace the address with 240.0.0.0, which is reserved for future use and less likely to be reachable. Author: Michael Han <michael@lianghan.org> Author: Michael Han <hanm@apache.org> Reviewers: Christopher Tubbs <ctubbsii@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1511 from hanm/fixut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Test MultipleAddressTest::testGetValidAddressWithNotValid might fail deterministically when the address it's using, 10.0.0.1, is reachable, as per https://tools.ietf.org/html/rfc5735 10.0.0.1 might be allocatable to private network usage. In fact, the router address of my ISP is assigned this IP, leading to this test always failing for me.
Solution:
Replace the address with 240.0.0.0, which is reserved for future use and less likely to be reachable.