ZOOKEEPER-4005:Zookeeper will not sync snapshot while get DIFF and cause start failed. #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallYellowCat
force-pushed
the
ZOOKEEPER-4005
branch
from
3a4a1bc
to
73f9509
Compare
|
@smallYellowCat Please try to add an unit test for this change. I'll take a closer look this patch at this weekend:) |
smallYellowCat
force-pushed
the
ZOOKEEPER-4005
branch
from
73f9509
to
1f8f1a6
Compare
@maoling Pls check the UT code, Thank you very much. |
maoling
reviewed
Dec 15, 2020
| String[] snaps = snapShotDir.list(new FilenameFilter() { | ||
| @Override | ||
| public boolean accept(File dir, String name) { | ||
| return name.contains("snapshot"); |
There was a problem hiding this comment.
Util.isSnapshotFileName(name)is better?- Just find one valid snapshot, then fast return true instead of iterating all?
- I still need a deeper thinking about this change, will come back soon. Sorry for the late.
There was a problem hiding this comment.
- Sometimes the
DIFFmessage is frequent, so the existing check of snapshot may be not cheap? Putting that check just before the real place oftakeSnapshotis more efficiency? - Another alternative way may be: allow users to take a snapshot themselves when upgrading by CLI or admin server command(take a snapshot immediately) that were PR-917 and PR-1044 wanted to do.
There was a problem hiding this comment.
Furthermore, we should answer this question: Why must we need a snapshot to restore at the start-up of server(a bit of a counter-intuitive)? we can remove this restriction without any consistency concerns?
There was a problem hiding this comment.
- this check only occurr during qurumpeer starting.
- the reason of check snapshot whether exist is prevent zk from starting in a subset and maybe become a leader.
smallYellowCat
force-pushed
the
ZOOKEEPER-4005
branch
from
1f8f1a6
to
12b4e68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZOOKEEPER-4005:Zookeeper will not sync snapshot while get DIFF and cause start failed.