Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4209: Update Netty to 4.1.53.Final #1604

Closed
wants to merge 1 commit into from

Conversation

frederiko
Copy link
Contributor

@frederiko frederiko commented Feb 14, 2021

Update Netty to 4.1.53.Final on 3.5 branch to address the vulnerability described at https://snyk.io/vuln/SNYK-JAVA-IONETTY-1020439

@maoling
Copy link
Member

maoling commented Feb 15, 2021

@frederiko

  • I saw that the current latest version is 4.1.59.Final, Why not choose this one ?
  • I observe the master also has that vulnerability, we can upgrade master firstly, then apply to branch-3.6 and branch-3.5 at the convenience
  • The vulnerability only affects the netty-codec-http component and ZooKeeper doesn't use that component?

@frederiko
Copy link
Contributor Author

frederiko commented Feb 15, 2021

@maoling

  • Good question. I don't see anything that could have prevented to be upgraded to 4.1.59.Final. Just tried to prevent any issues and address the issue at hand. In fact, I will change to the latest.
  • Yes, that can be done. However, for whatever reason mvn verify was breaking on my machine. Realized that maven was not too happy with openjdk version I had. Using zulu 11 has helped.
  • I don't think zookeeper uses that at all. My goal here is to have vulnerability scanning tools to get this one out of the way.

@frederiko
Copy link
Contributor Author

@maoling I have opened a new PR to address the issues above. #1605.

@frederiko
Copy link
Contributor Author

Closed in favor of #1605

@frederiko frederiko closed this Feb 16, 2021
@frederiko frederiko deleted the zookeeper-4209 branch February 16, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants