Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-4007: A typo in the ZKUtil#validateFileInput method #1687

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-4007: A typo in the ZKUtil#validateFileInput method #1687

wants to merge 1 commit into from

Conversation

benecdict-fang
Copy link
Contributor

No description provided.

ZWShuai91
ZWShuai91 approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@ZWShuai91 ZWShuai91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good,thanks

@maoling
Copy link
Member

maoling commented May 9, 2021

  • The CI has passed and I retest this change by this approach:
➜  bin ./zkSnapShotToolkit.sh /data/software
'/data/software' is a directory. it must be a file.
2021-05-09 18:33:28,685 [myid:] - ERROR [main:ServiceUtils@42] - Exiting JVM with code 2
  • if no other concerns, I'll merge it at next weekend(05-15)

@asfgit asfgit closed this in f5c29aa May 10, 2021
@maoling
Copy link
Member

maoling commented May 10, 2021

@benecdict-fang Thanks for your contribution.

anuragmadnawat1 pushed a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 2, 2022
@benecdict-fang @anurag-harness
ZOOKEEPER-4007: A typo in the ZKUtil#validateFileInput method
7ef7332 
Author: fangxiao <benec.fx@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>,  maoling <maoling@apache.org>

Closes apache#1687 from benecdict-fang/ZOOKEEPER-4007
@anuragmadnawat1 anuragmadnawat1 mentioned this pull request Nov 2, 2022
Merged
anuragmadnawat1 added a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 2, 2022
@anuragmadnawat1 @benecdict-fang
ZOOKEEPER-4007: A typo in the ZKUtil#validateFileInput method (#143)
00a971c 
Author: fangxiao <benec.fx@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>,  maoling <maoling@apache.org>

Closes apache#1687 from benecdict-fang/ZOOKEEPER-4007

Co-authored-by: fangxiao <benec.fx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@ZWShuai91 ZWShuai91 ZWShuai91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@benecdict-fang @maoling @eolivelli @ZWShuai91