ZOOKEEPER-4446 branch-3.6 txnLogCountTest use wrong version of Junit Assert import #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoling
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
- +1. Great catch. This issue was introduced by PR-1744 when I applied that patch to
branch-3.6which without usingjunit-5and no code conflicts - @eolivelli PTAL
|
sorry, I just merged ZooKeeper 3988 to branch 3.6, and fixed this issue together with the similar junit issue in that PR to make it work. I was not aware that this was already discovered and you already prepared a separate PR for txnLogCountTest. |
|
no worry, anyone who trying to build branch-3.6 will notice anyway. I was just surprise this is broken for quite sometime when I try to build to validate this branch with latest jetty server. May be we can closed this PR now. |
XiaoyiPeng
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mean to fix the invalid import static for junit Assert that only available in Junit 5.