Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-4462: Update Netty tcnative to 2.0.48 #1810

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-4462: Update Netty tcnative to 2.0.48 #1810

wants to merge 1 commit into from

Conversation

eolivelli
Copy link
Contributor

No description provided.

@eolivelli eolivelli self-assigned this Jan 30, 2022
@eolivelli
Copy link
Contributor Author

please merge to branch-3.7 and branch-3.6.

branch-3.5 needs a separate patch, as we have to fix Ant/Ivy files

@symat
Copy link
Contributor

symat commented Jan 31, 2022

I retriggered CI. We had this test failing before:

 RequestPathMetricsCollectorTest.testMultiThreadPerf:445 expected: <true> but was: <false>

@eolivelli
Copy link
Contributor Author

CPP tests failed, restarted CI again

@eolivelli
Copy link
Contributor Author

@symat CI passed
can you please help me merging this patch ?
also cherry picking to 3.7 and 3.6 is good

you will see less conflict if you merge these other patch before this one
#1808

thanks

symat
symat approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@symat symat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge it soon

@asfgit asfgit closed this in 1bdba02 Jan 31, 2022
asfgit pushed a commit that referenced this pull request Jan 31, 2022
@eolivelli @symat
ZOOKEEPER-4462: Update Netty tcnative to 2.0.48
d4bcb42 
Author: Enrico Olivelli <eolivelli@apache.org>

Reviewers: Mate Szalay-Beko <symat@apache.org>

Closes #1810 from eolivelli/ZOOKEEPER-4462
asfgit pushed a commit that referenced this pull request Jan 31, 2022
@eolivelli @symat
ZOOKEEPER-4462: Update Netty tcnative to 2.0.48
e074443 
Author: Enrico Olivelli <eolivelli@apache.org>

Reviewers: Mate Szalay-Beko <symat@apache.org>

Closes #1810 from eolivelli/ZOOKEEPER-4462
desaikomal pushed a commit to linkedin/zookeeper that referenced this pull request Jun 17, 2023
@eolivelli @desaikomal
ZOOKEEPER-4462: Update Netty tcnative to 2.0.48
598fac8 
Author: Enrico Olivelli <eolivelli@apache.org>

Reviewers: Mate Szalay-Beko <symat@apache.org>

Closes apache#1810 from eolivelli/ZOOKEEPER-4462
desaikomal pushed a commit to linkedin/zookeeper that referenced this pull request Jun 27, 2023
@eolivelli @desaikomal
ZOOKEEPER-4462: Update Netty tcnative to 2.0.48
ea18645 
Author: Enrico Olivelli <eolivelli@apache.org>

Reviewers: Mate Szalay-Beko <symat@apache.org>

Closes apache#1810 from eolivelli/ZOOKEEPER-4462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symat symat symat approved these changes

@cnauroth cnauroth Awaiting requested review from cnauroth

Assignees

@eolivelli eolivelli

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eolivelli @symat