ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have test cases that cover the two modes? Batch = 0 and batch > 0? |
symat
approved these changes
Apr 6, 2022
|
we should cherry-pick this to all the active branches (3.6, 3.7, 3.8) |
asfgit
pushed a commit
that referenced
this pull request
Apr 6, 2022
…nctionality Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes #1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality (cherry picked from commit 54cb5c3) Signed-off-by: Mohammad Arshad <arshad@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Apr 6, 2022
…nctionality Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes #1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality (cherry picked from commit 54cb5c3) Signed-off-by: Mohammad Arshad <arshad@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Apr 6, 2022
…nctionality Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes #1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality (cherry picked from commit 54cb5c3) Signed-off-by: Mohammad Arshad <arshad@apache.org>
|
Thanks @eolivelli, @symat for the reviews. Merged to master, branch-3.8, branch-3.7 and branch-3.6 |
anuragmadnawat1
pushed a commit
to anuragmadnawat1/zookeeper
that referenced
this pull request
Nov 1, 2022
…nctionality Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality
anuragmadnawat1
added a commit
to anuragmadnawat1/zookeeper
that referenced
this pull request
Nov 1, 2022
…nctionality (#53) Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality Co-authored-by: Mohammad Arshad <arshad@apache.org>
anurag-harness
pushed a commit
to anurag-harness/zookeeper
that referenced
this pull request
Jan 13, 2023
…nctionality Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality
anurag-harness
added a commit
to anurag-harness/zookeeper
that referenced
this pull request
Jan 13, 2023
…nctionality (#20) Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality Co-authored-by: Mohammad Arshad <arshad@apache.org>
desaikomal
pushed a commit
to linkedin/zookeeper
that referenced
this pull request
Jun 17, 2023
…nctionality Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality (cherry picked from commit 54cb5c3) Signed-off-by: Mohammad Arshad <arshad@apache.org>
desaikomal
pushed a commit
to linkedin/zookeeper
that referenced
this pull request
Jun 27, 2023
…nctionality Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality (cherry picked from commit 54cb5c3) Signed-off-by: Mohammad Arshad <arshad@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ZKUtil#deleteRecursive API fully compatible with older versions