ZOOKEEPER-4398: Add configurable Prometheus metric name prefix. #1909
+78
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i need this to be merged too. Metrics in this state/name are unbrowsable/unusable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ZOOKEEPER-4398 by adding an optional metric configuration property for a string prefix for all Zookeeper metric names.
It's common to have Prometheus metrics scoped to a namespace by using the application name as its prefix. For instance, Apache Kafka metrics have the prefix of
kafka_, making them easier to identify.This new config could be used to namespace Zookeeper metrics (e.g.
zookeeper_upinstead of simplyup). The default behavior does not use a prefix.