Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the need for local sessions within the readonly mode #1922

Merged
merged 1 commit into from Feb 6, 2024

Conversation

Hinterwaeldlers
Copy link
Contributor

Starting with commit c47ef90 the readonly mode requires local sessions to be activated.
This commit appends the related information to the docu.

In addition the impossibility to a client downgrade is noted

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting.

we should probably set localSessionsEnabled=true
it is no more a new feature

@eolivelli
Copy link
Contributor

what happens if you do not enable them ?

@Hinterwaeldlers
Copy link
Contributor Author

what happens if you do not enable them ?

The server is not serving any requests

I consider changing the behaviour within the code. But haven't found a sweet spot to activate the local session handling.

A different solution would be to change the behaviour of the session validation:

protected void validateSession(ServerCnxn cnxn, long sessionId) throws IOException {

In addition I am not sure, if Local-Sessions should be activated in regular mode or if there might be a scenario, where this leads to an unexpected behaviour

@maoling maoling merged commit d6c1cb5 into apache:master Feb 6, 2024
@maoling
Copy link
Member

maoling commented Feb 6, 2024

@Hinterwaeldlers
Thanks for your contribution.

AlphaCanisMajoris pushed a commit to AlphaCanisMajoris/zookeeper that referenced this pull request Mar 28, 2024
Reviewers: eolivelli, maoling
Author: Hinterwaeldlers
Closes apache#1922 from Hinterwaeldlers/readOnlyDocu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants