ZOOKEEPER-4674 TestReadOnlyClient.cc: Stop/start "normal" server in test setUp/tearDown #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2023
|
Assuming that @ztzg agrees with the patch, as he is the original author, I will merge the patch to all the active branches in order to unlock CI |
ztzg
approved these changes
Feb 13, 2023
I haven't /tested/ this patch, but it looks like what we came up with before, just with a proper ticket and description. LGTM! |
desaikomal
pushed a commit
to linkedin/zookeeper
that referenced
this pull request
Jun 17, 2023
… test setUp/tearDown (apache#1983) Co-authored-by: Damien Diederen <dd@crosstwine.com> (cherry picked from commit 2d1bac7)
desaikomal
pushed a commit
to linkedin/zookeeper
that referenced
this pull request
Jun 27, 2023
… test setUp/tearDown (apache#1983) Co-authored-by: Damien Diederen <dd@crosstwine.com> (cherry picked from commit 2d1bac7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.