Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4707: Upgrade snappy-java to address multiple CVEs #2014

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 19, 2023

@lhotari
Copy link
Member Author

lhotari commented Jun 20, 2023

@eolivelli Please review

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@symat symat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lhotari for your PR, this is very important for us, because we plan to release 3.8.2 and 3.9.0 soon.

Could you please also rename the related license file (see in https://github.com/apache/zookeeper/tree/master/zookeeper-server/src/main/resources/lib ) from snappy-java-1.1.9.1.jar_LICENSE.txt to snappy-java-1.1.10.1.jar_LICENSE.txt ?

If you can do the rename, I can approve and merge your PR to all active branches. Please let me know if you don't have the time, then I can create an other PR.

Thank you for your time and help!

@lhotari lhotari requested a review from symat July 3, 2023 15:24
@lhotari
Copy link
Member Author

lhotari commented Jul 3, 2023

@symat Thanks for the review. I renamed the license file. PTAL

Copy link
Contributor

@symat symat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @lhotari !!
I am merging it now to all active branches (master, branch-3.8, branch-3.7)

@symat symat merged commit 4661437 into apache:master Jul 4, 2023
14 checks passed
anurag-harness added a commit to anurag-harness/zookeeper that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants