-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZOOKEEPER-4707: Upgrade snappy-java to address multiple CVEs #2014
Conversation
@eolivelli Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lhotari for your PR, this is very important for us, because we plan to release 3.8.2 and 3.9.0 soon.
Could you please also rename the related license file (see in https://github.com/apache/zookeeper/tree/master/zookeeper-server/src/main/resources/lib ) from snappy-java-1.1.9.1.jar_LICENSE.txt
to snappy-java-1.1.10.1.jar_LICENSE.txt
?
If you can do the rename, I can approve and merge your PR to all active branches. Please let me know if you don't have the time, then I can create an other PR.
Thank you for your time and help!
@symat Thanks for the review. I renamed the license file. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @lhotari !!
I am merging it now to all active branches (master, branch-3.8, branch-3.7)
Address multiple CVEs: CVE-2023-34453 CVE-2023-34454 CVE-2023-34455 See https://github.com/xerial/snappy-java/releases/tag/v1.1.10.1 (cherry picked from commit 4661437)
Address multiple CVEs: CVE-2023-34453 CVE-2023-34454 CVE-2023-34455 See https://github.com/xerial/snappy-java/releases/tag/v1.1.10.1 (cherry picked from commit 4661437)
…2014) (#67) Address multiple CVEs: CVE-2023-34453 CVE-2023-34454 CVE-2023-34455 See https://github.com/xerial/snappy-java/releases/tag/v1.1.10.1 Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
Address multiple CVEs:
CVE-2023-34453
CVE-2023-34454
CVE-2023-34455
See https://github.com/xerial/snappy-java/releases/tag/v1.1.10.1