Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4393: [ADDENDUM] Turn off FIPS-mode by default on branch-3.8 #2016

Merged
merged 1 commit into from Jun 20, 2023

Conversation

anmolnar
Copy link
Contributor

@anmolnar anmolnar commented Jun 19, 2023

Accidentally enabled for 3.8 too when cherry-picked from master. We need to switch this off to maintain compatibility.

cc @symat

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I wonder if this should break some tests...
on master branch the default is "true" that means that all TLS tests require FIPS mode
maybe it is not a big deal, but actually the way we run the tests in which we don't explicitly set this property will run in a different way.

I am still +1 to this patch and I am +1 to commit it without adding/changing existing tests

@anmolnar
Copy link
Contributor Author

@eolivelli All true, I was thinking about it too. Most tests should be independent from this setting, since it only affects encryption in server-server and client-server comm. Those tests which are affected have already been extended with this setting (I hope).

That said, an accurate review is always welcome. Not sure if @symat is around for instance... ;)

@eolivelli eolivelli merged commit edcc3c1 into apache:branch-3.8 Jun 20, 2023
6 checks passed
@anmolnar anmolnar deleted the ZOOKEEPER-4393_c branch July 18, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants