Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZOOKEEPER-4719] Use Bouncycastle jdk18on instead of jdk15on #2033

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

shoothzj
Copy link
Member

No description provided.

@shoothzj shoothzj changed the title Bouncycastle jdk18on test [ZOOKEEPER-4719] Use Bouncycastle jdk18on instead of jdk15on Jul 12, 2023
@shoothzj
Copy link
Member Author

@maoling @tisonkun PTAL, thanks

@tisonkun tisonkun requested a review from anmolnar July 14, 2023 05:27
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't there License files to update?

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. (address @eolivelli 's comment plz)

@shoothzj
Copy link
Member Author

@eolivelli @anmolnar The bouncycastle dependency now only used in test dependencies. There 's no license file related to bouncycastle now.

ls -1 zookeeper-server/src/main/resources/lib
commons-cli-1.5.0.LICENSE.txt
commons-io-2.11.0.LICENSE.txt
jetty-http-9.4.51.v20230217.LICENSE.txt
jetty-io-9.4.51.v20230217.LICENSE.txt
jetty-security-9.4.51.v20230217.LICENSE.txt
jetty-server-9.4.51.v20230217.LICENSE.txt
jetty-servlet-9.4.51.v20230217.LICENSE.txt
jetty-util-9.4.51.v20230217.LICENSE.txt
jetty-util-ajax-9.4.51.v20230217.LICENSE.txt
jline-2.14.6.LICENSE.txt
logback-classic-1.2.10.LICENSE.txt
logback-core-1.2.10.LICENSE.txt
metrics-core-4.1.12.1.jar_LICENSE.txt
netty-bom-4.1.94.Final.LICENSE.txt
netty-buffer-4.1.94.Final.LICENSE.txt
netty-codec-4.1.94.Final.LICENSE.txt
netty-common-4.1.94.Final.LICENSE.txt
netty-handler-4.1.94.Final.LICENSE.txt
netty-resolver-4.1.94.Final.LICENSE.txt
netty-transport-4.1.94.Final.LICENSE.txt
netty-transport-native-epoll-4.1.94.Final.LICENSE.txt
netty-transport-native-unix-common-4.1.94.Final.LICENSE.txt
simpleclient-0.9.0.LICENSE.txt
simpleclient_common-0.9.0_LICENSE.txt
simpleclient_hotspot-0.9.0_LICENSE.txt
simpleclient_servlet-0.9.0_LICENSE.txt
slf4j-1.7.30.LICENSE.txt
snappy-java-1.1.10.1.jar_LICENSE.txt

@shoothzj
Copy link
Member Author

ping @eolivelli @anmolnar

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that bcprov is optionally used and can be dynamically loaded. See the touched zookeeperAdmin.md file for details.

Merging...

@tisonkun tisonkun merged commit 4882f7b into apache:master Jul 17, 2023
14 checks passed
@shoothzj shoothzj deleted the bouncycastle-jdk18on branch July 17, 2023 10:24
rahulrane50 pushed a commit to rahulrane50/zookeeper that referenced this pull request Sep 15, 2023
AlphaCanisMajoris pushed a commit to AlphaCanisMajoris/zookeeper that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants