-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZOOKEEPER-4719] Use Bouncycastle jdk18on instead of jdk15on #2033
Conversation
0b52cff
to
bfaf494
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't there License files to update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. (address @eolivelli 's comment plz)
@eolivelli @anmolnar The bouncycastle dependency now only used in test dependencies. There 's no license file related to bouncycastle now.
|
ping @eolivelli @anmolnar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that bcprov is optionally used and can be dynamically loaded. See the touched zookeeperAdmin.md
file for details.
Merging...
No description provided.