ZOOKEEPER-2623: [ADDENDUM] Forbid OpCode.check outside OpCode.multi #2104
+16
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual
OpCode.check
will getUnimplementedException
.JIRA: ZOOKEEPER-2623
Discussion thread: https://lists.apache.org/thread/vl816jfrklvqz29coz5qnwpom9q41pcg
This pr reworks/reverts #1988, which return an empty response for individual
OpCode.check
, for the following reasons:OpCode.check
is covered byOpCode.exists
.Open this pr for easy evaluation. I will reply the discussion thread for reference.
I plan to open a draft backport on branch-3.9 to ease code review if we are willing to go this direction.