Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2623: [ADDENDUM] Forbid OpCode.check outside OpCode.multi #2104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kezhuw
Copy link
Member

@kezhuw kezhuw commented Jan 9, 2024

Individual OpCode.check will get UnimplementedException.

JIRA: ZOOKEEPER-2623
Discussion thread: https://lists.apache.org/thread/vl816jfrklvqz29coz5qnwpom9q41pcg

This pr reworks/reverts #1988, which return an empty response for individual OpCode.check, for the following reasons:

  • The individual OpCode.check is covered by OpCode.exists.
  • In certain situation, we may want to differentiate the two(individual or not), say statistics. This could cause maintenance burden for us.
  • Exposing opcode without explicit API is probably not a good.

Open this pr for easy evaluation. I will reply the discussion thread for reference.

I plan to open a draft backport on branch-3.9 to ease code review if we are willing to go this direction.

Individual `OpCode.check` will get `UnimplementedException`.
@kezhuw
Copy link
Member Author

kezhuw commented Jan 9, 2024

I have opened #2105 onto branch-3.9 without commits from #1988 so to make it clean for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant